-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update from _rust template #576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
epage
commented
Feb 3, 2025
- Tests created for any new feature or regression tests for bugfixes.
…thon-5.x chore(deps): update actions/setup-python action to v5
…tion-3.x chore(deps): update github/codeql-action action to v3
…n-3.x chore(deps): Update pre-commit/action action to v3.0.1
We might want to hold one or the other back
Now that we run clippy on stable, we can do this
This works well when a package is a safe abstraction but to universally apply in a template to all members of a workspace doesn't make sense.
This makes clippy warn about `format!("{}", var)`, with a machine-applicable fix converting to `format!("{var}")`.
…ormat-args Have clippy warn about uninlined format arguments
…rgo-deny-action-2.x chore(deps): Update EmbarkStudios/cargo-deny-action action to v2
This is needed with the ubuntu-24.04 images so that `setup-python` will install a version of Python that the pre-commit action can install into. See pre-commit/action#210 for more of an analysis of this.
chore: Ensure pre-commit gets non-system Python
Update CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.