naughty: Allow pf-v5-c* CSS selectors #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cockpit-project/cockpit#18806 updated cockpit's PatternFly to the latest V5 alpha. That renamed all "pf-c-*" classes to "pf-v5-c*". Adjust our naughties to get along with either, which will fix the current cockpit main runs, as well as the other projects that will get ported to the latest PF5 soon.
jelly
approved these changes
May 22, 2023
KKoukiou
approved these changes
May 22, 2023
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cockpit-project/cockpit#18806 updated cockpit's PatternFly to the latest V5 alpha. That renamed all
pf-c-*classes topf-v5-c*. Adjust our naughties to get along with either, which will fix the current cockpit main runs, as well as the other projects that will get ported to the latest PF5 soon.This unfortunately already broke main, e.g. in this run of cockpit-project/cockpit#18829