package.json: Update @patternfly/patternfly, @patternfly/react-core, @patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table #18806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2023
…@patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table Closes #18806
github-actions
bot
force-pushed
the
npm-update-patternfly-patternfly-20230515-030714
branch
from
f6f80f7 to
a98d931
Compare
|
Please manually check features related to these files: |
martinpitt
pushed a commit
that referenced
this pull request
May 15, 2023
…@patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table Closes #18806
martinpitt
force-pushed
the
npm-update-patternfly-patternfly-20230515-030714
branch
from
a98d931 to
4844d2c
Compare
This was referenced May 15, 2023
KKoukiou
pushed a commit
that referenced
this pull request
May 16, 2023
…@patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table Closes #18806
KKoukiou
force-pushed
the
npm-update-patternfly-patternfly-20230515-030714
branch
from
4844d2c to
d32f52b
Compare
KKoukiou
added
the
no-test
KKoukiou
pushed a commit
that referenced
this pull request
May 17, 2023
…@patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table Closes #18806
KKoukiou
force-pushed
the
npm-update-patternfly-patternfly-20230515-030714
branch
from
d32f52b to
2cf83ae
Compare
KKoukiou
pushed a commit
that referenced
this pull request
May 17, 2023
…@patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table And pin down react-tokens as the newly released version is not compatible with this update. Closes #18806
KKoukiou
force-pushed
the
npm-update-patternfly-patternfly-20230515-030714
branch
5 times, most recently
from
d09a699 to
854ac75
Compare
KKoukiou
pushed a commit
that referenced
this pull request
May 19, 2023
…@patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table And pin down react-tokens as the newly released version is not compatible with this update. Closes #18806
KKoukiou
force-pushed
the
npm-update-patternfly-patternfly-20230515-030714
branch
2 times, most recently
from
8229532 to
37a151a
Compare
…@patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table And pin down react-tokens as the newly released version is not compatible with this update. Closes #18806
patternfly/patternfly#5376 I don't really see through this change therefore I asked here: patternfly/patternfly#5376
`RedHatText` is now the default font.
This can be reverted once the following issue is fixed: patternfly/patternfly-react#9128
KKoukiou
force-pushed
the
npm-update-patternfly-patternfly-20230515-030714
branch
from
37a151a to
f9e27a7
Compare
Expected changes are the following: * Default Icon size is now slightly smaller [1] * Flex changed the default spacing [1] patternfly/patternfly#5525
KKoukiou
removed
the
no-test
KKoukiou
force-pushed
the
npm-update-patternfly-patternfly-20230515-030714
branch
from
f9e27a7 to
54b4f0d
Compare
martinpitt
approved these changes
May 19, 2023
cockpituous
reviewed
May 20, 2023
| @@ -98,7 +98,7 @@ export const PasswordFormFields = ({ | |||
| labelIcon={password_label_info && | |||
| <Popover bodyContent={password_label_info}> | |||
| <button onClick={e => e.preventDefault()} | |||
| className="pf-c-form__group-label-help"> | |||
| className="pf-v5-c-form__group-label-help"> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -191,18 +191,18 @@ export const BondDialog = ({ connection, dev, settings }) => { | |||
| </FormSelect> | |||
| </FormGroup> | |||
| <FormGroup fieldId={idPrefix + "-link-monitoring-interval-input"} label={_("Monitoring interval")}> | |||
| <TextInput id={idPrefix + "-link-monitoring-interval-input"} className="network-number-field" value={linkMonitoringInterval} onChange={setLinkMonitoringInterval} /> | |||
| <TextInput id={idPrefix + "-link-monitoring-interval-input"} className="network-number-field" value={linkMonitoringInterval} onChange={(_event, value) => setLinkMonitoringInterval(value)} /> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| </FormGroup> | ||
| {linkMonitoring == 'mii' && <> | ||
| <FormGroup fieldId={idPrefix + "-link-up-delay-input"} label={_("Link up delay")}> | ||
| <TextInput id={idPrefix + "-link-up-delay-input"} className="network-number-field" value={linkUpDelay} onChange={setLinkUpDelay} /> | ||
| <TextInput id={idPrefix + "-link-up-delay-input"} className="network-number-field" value={linkUpDelay} onChange={(_event, value) => setLinkUpDelay(value)} /> |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| </FormGroup> | ||
| <FormGroup fieldId={idPrefix + "-link-down-delay-input"} label={_("Link down delay")}> | ||
| <TextInput id={idPrefix + "-link-down-delay-input"} className="network-number-field" value={linkDownDelay} onChange={setLinkDownDelay} /> | ||
| <TextInput id={idPrefix + "-link-down-delay-input"} className="network-number-field" value={linkDownDelay} onChange={(_event, value) => setLinkDownDelay(value)} /> |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -104,16 +104,16 @@ export const BridgeDialog = ({ connection, dev, settings }) => { | |||
| <Checkbox id={idPrefix + "-stp-enabled-input"} isChecked={stp} onChange={(_, s) => setStp(s)} label={_("Spanning tree protocol (STP)")} /> | |||
| {stp && <> | |||
| <FormGroup fieldId="network-bridge-stp-settings-priority-input" label={_("STP priority")}> | |||
| <TextInput id="network-bridge-stp-settings-priority-input" className="network-number-field" value={priority} onChange={setPriority} /> | |||
| <TextInput id="network-bridge-stp-settings-priority-input" className="network-number-field" value={priority} onChange={(_event, value) => setPriority(value)} /> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -142,7 +142,7 @@ export class FilesystemsPanel extends React.Component { | |||
| title: <StorageUsageBar stats={[Number(fs.Used[0] && Number(fs.Used[1])), | |||
| Number(pool.TotalPhysicalSize)]} | |||
| critical={1} total={total} offset={offsets[i]} />, | |||
| props: { className: "pf-u-text-align-right" } | |||
| props: { className: "pf-v5-u-text-align-right" } | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -157,7 +157,7 @@ export class StorageOnOff extends React.Component { | |||
| render() { | |||
| const self = this; | |||
|
|
|||
| function onChange(val) { | |||
| function onChange(_event, val) { | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| <div className={"pf-c-progress pf-m-outside pf-m-singleline" + (fraction > critical ? " pf-m-danger" : "") + (small ? " pf-m-sm" : "")}> | ||
| <div className="pf-c-progress__status" aria-hidden="true"> | ||
| <span className="pf-c-progress__measure">{labelText}</span> | ||
| <div className={"pf-v5-c-progress pf-m-outside pf-m-singleline" + (fraction > critical ? " pf-m-danger" : "") + (small ? " pf-m-sm" : "")}> |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -286,10 +286,10 @@ const PageSystemInformationChangeHostname = () => { | |||
| > | |||
| <Form isHorizontal onSubmit={onSubmit}> | |||
| <FormGroup fieldId="sich-pretty-hostname" label={_("Pretty host name")}> | |||
| <TextInput id="sich-pretty-hostname" value={pretty} onChange={onPrettyChanged} /> | |||
| <TextInput id="sich-pretty-hostname" value={pretty} onChange={(_event, value) => onPrettyChanged(value)} /> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| </FormGroup> | ||
| <FormGroup fieldId="sich-hostname" label={_("Real host name")}> | ||
| <TextInput id="sich-hostname" value={hostname} onChange={onHostnameChanged} validated={error.length ? "error" : "default"} /> | ||
| <TextInput id="sich-hostname" value={hostname} onChange={(_event, value) => onHostnameChanged(value)} validated={error.length ? "error" : "default"} /> |
There was a problem hiding this comment.
This added line is not executed by any test. Details
cockpituous
reviewed
May 20, 2023
| @@ -98,7 +98,7 @@ export const PasswordFormFields = ({ | |||
| labelIcon={password_label_info && | |||
| <Popover bodyContent={password_label_info}> | |||
| <button onClick={e => e.preventDefault()} | |||
| className="pf-c-form__group-label-help"> | |||
| className="pf-v5-c-form__group-label-help"> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -191,18 +191,18 @@ export const BondDialog = ({ connection, dev, settings }) => { | |||
| </FormSelect> | |||
| </FormGroup> | |||
| <FormGroup fieldId={idPrefix + "-link-monitoring-interval-input"} label={_("Monitoring interval")}> | |||
| <TextInput id={idPrefix + "-link-monitoring-interval-input"} className="network-number-field" value={linkMonitoringInterval} onChange={setLinkMonitoringInterval} /> | |||
| <TextInput id={idPrefix + "-link-monitoring-interval-input"} className="network-number-field" value={linkMonitoringInterval} onChange={(_event, value) => setLinkMonitoringInterval(value)} /> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| </FormGroup> | ||
| {linkMonitoring == 'mii' && <> | ||
| <FormGroup fieldId={idPrefix + "-link-up-delay-input"} label={_("Link up delay")}> | ||
| <TextInput id={idPrefix + "-link-up-delay-input"} className="network-number-field" value={linkUpDelay} onChange={setLinkUpDelay} /> | ||
| <TextInput id={idPrefix + "-link-up-delay-input"} className="network-number-field" value={linkUpDelay} onChange={(_event, value) => setLinkUpDelay(value)} /> |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| </FormGroup> | ||
| <FormGroup fieldId={idPrefix + "-link-down-delay-input"} label={_("Link down delay")}> | ||
| <TextInput id={idPrefix + "-link-down-delay-input"} className="network-number-field" value={linkDownDelay} onChange={setLinkDownDelay} /> | ||
| <TextInput id={idPrefix + "-link-down-delay-input"} className="network-number-field" value={linkDownDelay} onChange={(_event, value) => setLinkDownDelay(value)} /> |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -104,16 +104,16 @@ export const BridgeDialog = ({ connection, dev, settings }) => { | |||
| <Checkbox id={idPrefix + "-stp-enabled-input"} isChecked={stp} onChange={(_, s) => setStp(s)} label={_("Spanning tree protocol (STP)")} /> | |||
| {stp && <> | |||
| <FormGroup fieldId="network-bridge-stp-settings-priority-input" label={_("STP priority")}> | |||
| <TextInput id="network-bridge-stp-settings-priority-input" className="network-number-field" value={priority} onChange={setPriority} /> | |||
| <TextInput id="network-bridge-stp-settings-priority-input" className="network-number-field" value={priority} onChange={(_event, value) => setPriority(value)} /> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -142,7 +142,7 @@ export class FilesystemsPanel extends React.Component { | |||
| title: <StorageUsageBar stats={[Number(fs.Used[0] && Number(fs.Used[1])), | |||
| Number(pool.TotalPhysicalSize)]} | |||
| critical={1} total={total} offset={offsets[i]} />, | |||
| props: { className: "pf-u-text-align-right" } | |||
| props: { className: "pf-v5-u-text-align-right" } | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -157,7 +157,7 @@ export class StorageOnOff extends React.Component { | |||
| render() { | |||
| const self = this; | |||
|
|
|||
| function onChange(val) { | |||
| function onChange(_event, val) { | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| <div className={"pf-c-progress pf-m-outside pf-m-singleline" + (fraction > critical ? " pf-m-danger" : "") + (small ? " pf-m-sm" : "")}> | ||
| <div className="pf-c-progress__status" aria-hidden="true"> | ||
| <span className="pf-c-progress__measure">{labelText}</span> | ||
| <div className={"pf-v5-c-progress pf-m-outside pf-m-singleline" + (fraction > critical ? " pf-m-danger" : "") + (small ? " pf-m-sm" : "")}> |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -286,10 +286,10 @@ const PageSystemInformationChangeHostname = () => { | |||
| > | |||
| <Form isHorizontal onSubmit={onSubmit}> | |||
| <FormGroup fieldId="sich-pretty-hostname" label={_("Pretty host name")}> | |||
| <TextInput id="sich-pretty-hostname" value={pretty} onChange={onPrettyChanged} /> | |||
| <TextInput id="sich-pretty-hostname" value={pretty} onChange={(_event, value) => onPrettyChanged(value)} /> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| </FormGroup> | ||
| <FormGroup fieldId="sich-hostname" label={_("Real host name")}> | ||
| <TextInput id="sich-hostname" value={hostname} onChange={onHostnameChanged} validated={error.length ? "error" : "default"} /> | ||
| <TextInput id="sich-hostname" value={hostname} onChange={(_event, value) => onHostnameChanged(value)} validated={error.length ? "error" : "default"} /> |
There was a problem hiding this comment.
This added line is not executed by any test. Details
martinpitt
pushed a commit
that referenced
this pull request
May 20, 2023
…@patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table And pin down react-tokens as the newly released version is not compatible with this update. Closes #18806
This was referenced May 22, 2023
martinpitt
added a commit
to martinpitt/bots
that referenced
this pull request
May 22, 2023
cockpit-project/cockpit#18806 updated cockpit's PatternFly to the latest V5 alpha. That renamed all "pf-c-*" classes to "pf-v5-c*". Adjust our naughties to get along with either, which will fix the current cockpit main runs, as well as the other projects that will get ported to the latest PF5 soon.
martinpitt
added a commit
to cockpit-project/bots
that referenced
this pull request
May 22, 2023
cockpit-project/cockpit#18806 updated cockpit's PatternFly to the latest V5 alpha. That renamed all "pf-c-*" classes to "pf-v5-c*". Adjust our naughties to get along with either, which will fix the current cockpit main runs, as well as the other projects that will get ported to the latest PF5 soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be squashed on merge.