Some small fixes #39
Merged
Some small fixes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out get_auth_request(), so that we can re-use it for other scenarios. Remember the last exception and print it in the timeout failure message, for better debugging.
If they crash, removal makes the logs disappear, which makes debugging hard. `make clean` removes them anyway, so there is no risk of permanently leaking them.
This is conceptually broken -- the browser should decide when it wants to upgrade a connection to websocket, and we should just pass that through (like we do with `Upgrade:` already). This is also what the real 3scale does, so more faithfully reproduces its behaviour. This also helps to avoid aio-libs/aiohttp#4581
jelly
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken out of #37