Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small fixes #39

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Some small fixes #39

merged 3 commits into from
Sep 20, 2022

Commits on Sep 15, 2022

  1. test: Refactor request() helper method

    Split out get_auth_request(), so that we can re-use it for other
    scenarios.
    
    Remember the last exception and print it in the timeout failure message, for
    better debugging.
    martinpitt committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    16a55e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. appservice: Don't auto-remove session containers

    If they crash, removal makes the logs disappear, which makes debugging
    hard.
    
    `make clean` removes them anyway, so there is no risk of permanently
    leaking them.
    martinpitt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    458305f View commit details
    Browse the repository at this point in the history
  2. 3scale: Don't upgrade all connections

    This is conceptually broken -- the browser should decide when it wants
    to upgrade a connection to websocket, and we should just pass that
    through (like we do with `Upgrade:` already). This is also what the real
    3scale does, so more faithfully reproduces its behaviour.
    
    This also helps to avoid aio-libs/aiohttp#4581
    martinpitt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    2f2362d View commit details
    Browse the repository at this point in the history