-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
60485: cloudimpl: deprecation notice to GCS `default` cluster setting r=dt a=adityamaru We want to get rid of the `default` mode of AUTH for GCS in 21.2. This mode relies on a cluster setting being set with a JSON key. This change adds a deprecation warning to the description of that cluster settings. There will be a docs callout to accompany this change. Fixes: #60433 Release note: None 60510: migrations: add migration to remove pre-19.2 FK representation r=ajwerner a=ajwerner We've been carrying this old representation for a long time. This migration is written as simply as I can think to do it. It could perhaps be better. One thing this patch doesn't do is really enforce that it's gone. Probably we'll want to do that in validation for this cycle. In the next release we'll stop decoding the fields. The change should not be user visible so no release note. Release note: None 60770: colexec: extract multiple new packages r=yuzefovich a=yuzefovich This PR breaks down huge `colexec` package in order to speed up the build time (it was pointed out that the package is the bottleneck during bazel builds). With all of these changes, `colexec` (and its descendants) is barely visible when profiling the bazel build. The structure of dependencies is enforced by `dep_test` files added to the new packages. The following new packages have been extracted: - `colexecutils` which contains miscellaneous utility operators, structs, and functions that will be used by several other packages - `colexechash` which contains all of the code interacting directly with hashing of data (the hash table and the tuple hash distributor) - `colexecwindow` which contains all of the code related to window functions - `colexecargs` which contains the arguments to and the result of `NewColOperator` call - `colexecbase` which contains miscellaneous operators that have very few dependencies and are depended on by other operators that we want to extract from `colexec` - `colexeccmp` which contains shared objects between projection and selection operators (namely, LIKE ops- and default comparison- related things) - `colexecproj` and `colexecsel` which contain the projection and the selection operators, respectively - `colexecjoin` which contains the code for the in-memory joiners (cross, hash, and merge). Additionally, multiple other operators have been moved to more appropriate packages as well as the following package moves and renames were performed: - move `colexecerror` out of `sql/colexecbase` into `sql` - rename `sql/colexecbase` to `sql/colexecop`. See individual commits for details. 60928: sql: Enable IMPORT of tables into multi-region databases r=arulajmani,otan,pbardea a=ajstorm Previously, tables that were exported from non-multi-region databases were not able to be imported into multi-region databases. This commit enables the above operation. Note that the newly added test case also lays the groundwork for testing export from multi-region databases. Release note: None Resolves #59803. 60965: jobs: make Job.id an int64 instead of *int64 r=lucy-zhang a=lucy-zhang It's no longer valid to create in-memory `Job`s without IDs, so there's no reason to have the `id` field be a pointer anymore. This commit should also banish the common mistake of logging a `*int64` using `%d` when logging the job ID. Release note: None Co-authored-by: Aditya Maru <adityamaru@gmail.com> Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Adam Storm <storm@cockroachlabs.com> Co-authored-by: Lucy Zhang <lucy@cockroachlabs.com>
- Loading branch information
Showing
375 changed files
with
13,497 additions
and
10,963 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
pkg/ccl/logictestccl/testdata/logic_test/multi_region_import_export
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| # LogicTest: multiregion-9node-3region-3azs | ||
|
|
||
| query TTTT colnames | ||
| SHOW REGIONS | ||
| ---- | ||
| region zones database_names primary_region_of | ||
| ap-southeast-2 {ap-az1,ap-az2,ap-az3} {} {} | ||
| ca-central-1 {ca-az1,ca-az2,ca-az3} {} {} | ||
| us-east-1 {us-az1,us-az2,us-az3} {} {} | ||
|
|
||
| query TT colnames | ||
| SHOW REGIONS FROM CLUSTER | ||
| ---- | ||
| region zones | ||
| ap-southeast-2 {ap-az1,ap-az2,ap-az3} | ||
| ca-central-1 {ca-az1,ca-az2,ca-az3} | ||
| us-east-1 {us-az1,us-az2,us-az3} | ||
|
|
||
| statement ok | ||
| CREATE DATABASE non_multi_region_db | ||
|
|
||
| statement ok | ||
| CREATE DATABASE multi_region_test_db PRIMARY REGION "ca-central-1" REGIONS "ap-southeast-2", "us-east-1" SURVIVE REGION FAILURE | ||
|
|
||
| statement ok | ||
| USE multi_region_test_db; | ||
| CREATE TABLE regional_primary_region_table (a int) LOCALITY REGIONAL BY TABLE IN PRIMARY REGION | ||
|
|
||
| statement ok | ||
| CREATE TABLE "regional_us-east-1_table" (a int) LOCALITY REGIONAL BY TABLE IN "us-east-1" | ||
|
|
||
| statement ok | ||
| CREATE TABLE global_table (a int) LOCALITY GLOBAL | ||
|
|
||
| statement ok | ||
| CREATE TABLE regional_by_row_table ( | ||
| pk int PRIMARY KEY, | ||
| pk2 int NOT NULL, | ||
| a int NOT NULL, | ||
| b int NOT NULL, | ||
| j JSON, | ||
| INDEX (a), | ||
| UNIQUE (b), | ||
| INVERTED INDEX (j), | ||
| FAMILY (pk, pk2, a, b) | ||
| ) LOCALITY REGIONAL BY ROW | ||
|
|
||
| statement ok | ||
| use non_multi_region_db | ||
|
|
||
| statement ok | ||
| CREATE TABLE team ( | ||
| id int PRIMARY KEY, | ||
| name string, | ||
| likes string[], | ||
| dislikes string[] | ||
| ) | ||
|
|
||
| statement ok | ||
| INSERT INTO team VALUES (1, 'arulajmani', ARRAY['turkey','coffee','ps5'], ARRAY['going outside in winter','denormalization']); | ||
| INSERT INTO team VALUES (2, 'otan', ARRAY['Sydney suburbs','cricket','vim'], ARRAY['flaky tests','onboarding']) | ||
|
|
||
| query ITTT colnames | ||
| SELECT * FROM team | ||
| ---- | ||
| id name likes dislikes | ||
| 1 arulajmani {turkey,coffee,ps5} {"going outside in winter",denormalization} | ||
| 2 otan {"Sydney suburbs",cricket,vim} {"flaky tests",onboarding} | ||
|
|
||
| statement ok | ||
| EXPORT INTO CSV 'nodelocal://1/team_export/' WITH DELIMITER = '|' FROM TABLE team | ||
|
|
||
| statement ok | ||
| use multi_region_test_db; | ||
| IMPORT TABLE team ( | ||
| id int PRIMARY KEY, | ||
| name string, | ||
| likes string[], | ||
| dislikes string[] | ||
| ) | ||
| CSV DATA ('nodelocal://1/team_export/export*.csv') WITH DELIMITER = '|' | ||
|
|
||
| query ITTT colnames | ||
| SELECT * FROM team | ||
| ---- | ||
| id name likes dislikes | ||
| 1 arulajmani {turkey,coffee,ps5} {"going outside in winter",denormalization} | ||
| 2 otan {"Sydney suburbs",cricket,vim} {"flaky tests",onboarding} | ||
|
|
||
| query TT | ||
| SHOW CREATE TABLE team | ||
| ---- | ||
| team CREATE TABLE public.team ( | ||
| id INT8 NOT NULL, | ||
| name STRING NULL, | ||
| likes STRING[] NULL, | ||
| dislikes STRING[] NULL, | ||
| CONSTRAINT "primary" PRIMARY KEY (id ASC), | ||
| FAMILY "primary" (id, name, likes, dislikes) | ||
| ) LOCALITY REGIONAL BY TABLE IN PRIMARY REGION |
Oops, something went wrong.