jobs: make Job.id an int64 instead of *int64 #60965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
thoszhang
force-pushed
the
job-id-field
branch
3 times, most recently
from
affa3e6 to
08f2446
Compare
thoszhang
requested review from
dt and
ajwerner
and removed request for
a team
It's no longer valid to create in-memory `Job`s without IDs, so there's no reason to have the `id` field be a pointer anymore. This commit should also banish the common mistake of logging a `*int64` using `%d` when logging the job ID. Release note: None
thoszhang
force-pushed
the
job-id-field
branch
from
08f2446 to
f5ad15a
Compare
ajwerner
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Reviewed 30 of 30 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @dt)
|
TFTR bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no longer valid to create in-memory
Jobs without IDs, so there'sno reason to have the
idfield be a pointer anymore.This commit should also banish the common mistake of logging a
*int64using
%dwhen logging the job ID.Release note: None