Skip to content

Commit

Permalink
Merge #41215
Browse files Browse the repository at this point in the history
41215: roachpb: update the explanation of the TxnCoordMeta.refresh_invalid field r=andreimatei a=andreimatei

Release justification: only comments

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
  • Loading branch information
craig[bot] and andreimatei committed Sep 30, 2019
2 parents d1f5ea4 + fcc3dfc commit 7900bbf
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 33 deletions.
55 changes: 27 additions & 28 deletions pkg/roachpb/data.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions pkg/roachpb/data.proto
Original file line number Diff line number Diff line change
Expand Up @@ -635,11 +635,10 @@ message TxnCoordMeta {
repeated Span refresh_reads = 4 [(gogoproto.nullable) = false];
repeated Span refresh_writes = 5 [(gogoproto.nullable) = false];
reserved 6;
// refresh_invalid indicates that spans were discarded or not collected
// (i.e. because of a dist SQL processor running a version before refreshing
// was introduced). This is false if all spans encountered during the
// transaction which need refreshing have been collected to the refresh_reads
// and refresh_writes span slices.
// refresh_invalid indicates that spans were discarded or not collected (i.e.
// because the memory budget for tracking reads was exceeded). This is false
// if all spans encountered during the transaction which need refreshing have
// been collected to the refresh_reads and refresh_writes span slices.
bool refresh_invalid = 7;
// in_flight_writes stores all writes that are in-flight and have not yet
// been proven to have succeeded. Any client wishing to send a request that
Expand Down

0 comments on commit 7900bbf

Please sign in to comment.