roachpb: update the explanation of the TxnCoordMeta.refresh_invalid field #41215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+
…On Mon, Sep 30, 2019 at 3:14 PM Nathan VanBenschoten < ***@***.***> wrote:
***@***.**** approved this pull request.
[image: <img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src="https://reviewable.io/lgtm.png" height="20" width="61"/>]
<https://camo.githubusercontent.com/41b3ec3419116e3b3f84507ad965646ce4ce1f0c/68747470733a2f2f72657669657761626c652e696f2f6c67746d2e706e67>
Reviewed 1 of 1 files at r1.
*Reviewable
<https://reviewable.io/reviews/cockroachdb/cockroach/41215#-:-Lq2a36ZA244pJrof_Wr:bnfp4nl>*
status: [image:
] complete! 1 of 0 LGTMs obtained
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41215?email_source=notifications&email_token=AAC4C4OERFN5LYOQEQ5KC53QMJF2ZA5CNFSM4I37H4T2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGMEQ4Q#pullrequestreview-295192690>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC4C4PHBWO5L6JACEFCBPLQMJF2ZANCNFSM4I37H4TQ>
.
|
Build failed |
…ield Release justification: only comments Release note: None
andreimatei
force-pushed
the
small.refresh_invalid-comment
branch
from
559beee
to
fcc3dfc
Compare
|
bors r+
…On Mon, Sep 30, 2019 at 3:20 PM craig[bot] ***@***.***> wrote:
Build failed
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=1514774&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41215?email_source=notifications&email_token=AAC4C4KNZ34NAUHEV4T2XKLQMJGQ5A5CNFSM4I37H4T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD76ZGLY#issuecomment-536711983>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC4C4O3NY7BNL2XH5UHUJLQMJGQ5ANCNFSM4I37H4TQ>
.
|
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release justification: only comments
Release note: None