Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/changefeedccl: TestChangefeedEndTimeWithCursor failed #123720

Closed
cockroach-teamcity opened this issue May 7, 2024 · 2 comments · Fixed by #123733
Closed

ccl/changefeedccl: TestChangefeedEndTimeWithCursor failed #123720

cockroach-teamcity opened this issue May 7, 2024 · 2 comments · Fixed by #123733
Labels
A-cdc Change Data Capture branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 7, 2024 •
edited by cockroach-jira-scripts
Loading

ccl/changefeedccl.TestChangefeedEndTimeWithCursor failed on master @ e90d15c9807775a1a1d89f75cac4c9383c325709:

=== RUN   TestChangefeedEndTimeWithCursor
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestChangefeedEndTimeWithCursor3507104947
    test_log_scope.go:81: use -show-logs to present logs inline
    changefeed_test.go:7411: -- test log scope end --
test logs left over in: outputs.zip/logTestChangefeedEndTimeWithCursor3507104947
--- FAIL: TestChangefeedEndTimeWithCursor (48.22s)
=== RUN   TestChangefeedEndTimeWithCursor/pulsar
    helpers_test.go:864: making server as secondary tenant
    helpers_test.go:943: making pulsar feed factory
    changefeed_test.go:7394: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7394
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1104
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1139
        	Error:      	Received unexpected error:
        	            	still waiting for job status; current running
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.(*jobFeed).WaitForStatus.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/testfeed_test.go:440
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:75
        	            	  | github.com/cockroachdb/cockroach/pkg/util/retry.ForDuration
        	            	  | 	github.com/cockroachdb/cockroach/pkg/util/retry/retry.go:213
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError
        	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:81
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsSoonError
        	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:51
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.(*jobFeed).WaitForStatus
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/testfeed_test.go:431
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.TestChangefeedEndTimeWithCursor.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7394
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.cdcTestNamed.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1104
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.cdcTestNamedWithSystem.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1139
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1689
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_amd64.s:1695
        	            	Wraps: (2) still waiting for job status; current running
        	            	Error types: (1) *withstack.withStack (2) *errutil.leafError
        	Test:       	TestChangefeedEndTimeWithCursor/pulsar
    --- FAIL: TestChangefeedEndTimeWithCursor/pulsar (48.22s)

Parameters:

  • attempt=1
  • run=7
  • shard=12
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/cdc

This test on roachdash | Improve this report!

Jira issue: CRDB-38503
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc labels May 7, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone May 7, 2024
@blathers-crl blathers-crl bot added the A-cdc Change Data Capture label May 7, 2024
@wenyihu6 wenyihu6 mentioned this issue May 7, 2024
Merged
wenyihu6 added a commit to wenyihu6/cockroach that referenced this issue May 7, 2024
@wenyihu6
changefeedccl: skip flaky pulsar tests
74d8738 
This patch skips flaky tests for pulsar sinks. We will add them back when pulsar
is fully supported.

Release note: none
Fixes: cockroachdb#123718
Fixes: cockroachdb#121932
Fixes: cockroachdb#123720
Fixes: cockroachdb#123721
@cockroach-teamcity
Copy link
Member Author

ccl/changefeedccl.TestChangefeedEndTimeWithCursor failed with artifacts on master @ 956927d3830046bf4224e341fcd3d32eff68d0ee:

=== RUN   TestChangefeedEndTimeWithCursor
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/b4b4ff567208b3b36d9c1ab53c36b00f/logTestChangefeedEndTimeWithCursor163756783
    test_log_scope.go:81: use -show-logs to present logs inline
    changefeed_test.go:7411: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/b4b4ff567208b3b36d9c1ab53c36b00f/logTestChangefeedEndTimeWithCursor163756783
--- FAIL: TestChangefeedEndTimeWithCursor (54.80s)
=== RUN   TestChangefeedEndTimeWithCursor/pulsar
    helpers_test.go:864: making server as secondary tenant
    helpers_test.go:943: making pulsar feed factory
    changefeed_test.go:7394: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7394
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1104
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1139
        	Error:      	Received unexpected error:
        	            	still waiting for job status; current running
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.(*jobFeed).WaitForStatus.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/testfeed_test.go:440
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:75
        	            	  | github.com/cockroachdb/cockroach/pkg/util/retry.ForDuration
        	            	  | 	github.com/cockroachdb/cockroach/pkg/util/retry/retry.go:213
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError
        	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:81
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsSoonError
        	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:51
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.(*jobFeed).WaitForStatus
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/testfeed_test.go:431
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.TestChangefeedEndTimeWithCursor.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7394
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.cdcTestNamed.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1104
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.cdcTestNamedWithSystem.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1139
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1689
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_arm64.s:1222
        	            	Wraps: (2) still waiting for job status; current running
        	            	Error types: (1) *withstack.withStack (2) *errutil.leafError
        	Test:       	TestChangefeedEndTimeWithCursor/pulsar
    --- FAIL: TestChangefeedEndTimeWithCursor/pulsar (54.79s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

ccl/changefeedccl.TestChangefeedEndTimeWithCursor failed on master @ 5af437504d8629174387bcbe7cd764f0abb252e2:

=== RUN   TestChangefeedEndTimeWithCursor
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestChangefeedEndTimeWithCursor3945098795
    test_log_scope.go:81: use -show-logs to present logs inline
    changefeed_test.go:7411: -- test log scope end --
test logs left over in: outputs.zip/logTestChangefeedEndTimeWithCursor3945098795
--- FAIL: TestChangefeedEndTimeWithCursor (48.56s)
=== RUN   TestChangefeedEndTimeWithCursor/pulsar
    helpers_test.go:864: making server as secondary tenant
    helpers_test.go:943: making pulsar feed factory
    changefeed_test.go:7394: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7394
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1104
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1139
        	Error:      	Received unexpected error:
        	            	still waiting for job status; current running
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.(*jobFeed).WaitForStatus.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/testfeed_test.go:440
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:75
        	            	  | github.com/cockroachdb/cockroach/pkg/util/retry.ForDuration
        	            	  | 	github.com/cockroachdb/cockroach/pkg/util/retry/retry.go:213
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError
        	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:81
        	            	  | github.com/cockroachdb/cockroach/pkg/testutils.SucceedsSoonError
        	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:51
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.(*jobFeed).WaitForStatus
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/testfeed_test.go:431
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.TestChangefeedEndTimeWithCursor.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7394
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.cdcTestNamed.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1104
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.cdcTestNamedWithSystem.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/helpers_test.go:1139
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1689
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_amd64.s:1695
        	            	Wraps: (2) still waiting for job status; current running
        	            	Error types: (1) *withstack.withStack (2) *errutil.leafError
        	Test:       	TestChangefeedEndTimeWithCursor/pulsar
    --- FAIL: TestChangefeedEndTimeWithCursor/pulsar (48.55s)

Parameters:

  • attempt=1
  • run=1
  • shard=12
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@rharding6373 rharding6373 mentioned this issue May 7, 2024
Merged
craig bot pushed a commit that referenced this issue May 7, 2024
@rharding6373
Merge #123791
1fb89af 
123791: Revert "changefeedccl: make mock pulsar sink synchronous" r=rharding6373 a=rharding6373

Reverts #123228

This is causing flaky pulsar tests (e.g., #123720)

Epic: None

Release note: none

Co-authored-by: Rachael Harding <rharding6373@users.noreply.github.com>
craig bot pushed a commit that referenced this issue May 8, 2024
@wenyihu6
Merge #123733
7756496 
123733: changefeedccl: skip flaky pulsar tests r=rharding6373 a=wenyihu6

This patch skips flaky tests for pulsar sinks. We will add them back when pulsar
is fully supported.

Release note: none
Fixes: #123718
Fixes: #123719
Fixes: #123720
Fixes: #123721

Co-authored-by: Wenyi Hu <wenyi@cockroachlabs.com>
@craig craig bot closed this as completed in 8678912 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cdc Change Data Capture branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc
Projects
None yet
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

changefeedccl: skip flaky pulsar tests wenyihu6/cockroach
1 participant
@cockroach-teamcity