changefeedccl: skip flaky pulsar tests #123733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rharding6373
approved these changes
May 7, 2024
There was a problem hiding this comment.
This is fallout from making mock pulsar synchronous. 
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andyyang890)
|
Merging since I've seen this fail pretty often on my CI runs. bors r=rharding6373 |
This patch skips flaky tests for pulsar sinks. We will add them back when pulsar is fully supported. Release note: none Fixes: cockroachdb#123718 Fixes: cockroachdb#123719 Fixes: cockroachdb#123720 Fixes: cockroachdb#123721
|
Sorry for the noises! And thanks for the review. bors r=rharding6373 |
|
Build failed: |
|
bors run hit lots of preemptions 😞 bors r=rharding6373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch skips flaky tests for pulsar sinks. We will add them back when pulsar
is fully supported.
Release note: none
Fixes: #123718
Fixes: #123719
Fixes: #123720
Fixes: #123721