cdc: panics in nextFlushWithJitter when min_checkpoint_frequency is zero #125312
Assignees
Labels
A-cdc
Change Data Capture
backport-23.1.x
Flags PRs that need to be backported to 23.1
backport-23.2.x
Flags PRs that need to be backported to 23.2.
branch-release-24.1
Used to mark GA and release blockers, technical advisories, and bugs for 24.1
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-support
Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs
T-cdc
Comments
wenyihu6
added
the
C-bug
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Hi @wenyihu6, please add branch-* labels to identify which branch(es) this C-bug affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
cc @cockroachdb/cdc |
wenyihu6
added
O-support
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this issue
Jun 7, 2024
…int_frequency is set to 0 Previously, we introduced the cluster setting changefeed.aggregator.flush_jitter to apply some jitter to the aggregator flush frequency. This was done to reduce the load on the coordinator by spreading out aggregator flush times. However, that PR did not account for the case where min_checkpoint_frequency is set to zero, which could cause panics due to rand.Int63(0). This patch fixes the issue by adding a check for when the frequency is zero, ensuring that jitter is not applied in such cases. Fixes: cockroachdb#125312 Release note (bug fix): Fixed a bug in v24.1, v23.2, and v23.1 where using changefeed.aggregator.flush_jitter with min_checkpoint_frequency set to zero could cause panics.
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this issue
Jun 7, 2024
Previously, we introduced the cluster setting changefeed.aggregator.flush_jitter to apply some jitter to the aggregator flush frequency. This was done to reduce the load on the coordinator by spreading out aggregator flush times. However, that PR did not account for the case where min_checkpoint_frequency is set to zero, which could cause panics due to rand.Int63(0). This patch fixes the issue by adding a check for when the frequency is zero, ensuring that jitter is not applied in such cases. Fixes: cockroachdb#125312 Release note (bug fix): Fixed a bug in v24.1, v23.2, and v23.1 where using changefeed.aggregator.flush_jitter with min_checkpoint_frequency set to zero could cause panics.
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this issue
Jun 7, 2024
Previously, we introduced the cluster setting changefeed.aggregator.flush_jitter to apply some jitter to the aggregator flush frequency. This was done to reduce the load on the coordinator by spreading out aggregator flush times. However, that PR did not account for the case where min_checkpoint_frequency is set to zero, which could cause panics due to rand.Int63(0). This patch fixes the issue by adding a check for when the frequency is zero, ensuring that jitter is not applied in such cases. Fixes: cockroachdb#125312 Release note (bug fix): Fixed a bug in v24.1, v23.2, and v23.1 where using changefeed.aggregator.flush_jitter with min_checkpoint_frequency set to zero could cause panics.
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this issue
Jun 10, 2024
Previously, we introduced the cluster setting changefeed.aggregator.flush_jitter to apply some jitter to the aggregator flush frequency. This was done to reduce the load on the coordinator by spreading out aggregator flush times. However, that PR did not account for the case where min_checkpoint_frequency is set to zero, which could cause panics due to rand.Int63(0). This patch fixes the issue by adding a check for when the frequency is zero, ensuring that jitter is not applied in such cases. Fixes: cockroachdb#125312 Release note (bug fix): Fixed a bug in v24.1, v23.2, and v23.1 where using changefeed.aggregator.flush_jitter with min_checkpoint_frequency set to zero could cause panics.
craig bot
pushed a commit
that referenced
this issue
Jun 10, 2024
125226: tenantcostclient: convert tenant cost client to use token terminology r=andy-kimball a=andy-kimball Convert the tenant cost client to use token terminology rather than RU terminology. We are generalizing the tenant cost code to support vCPUs as an alternate measure of cost, and want more generic code that is agnostic to the particular unit of cost. This PR is purely mechanical and kept separate in order to reduce the size of later reviews. Epic: CC-28471 Release note: None 125317: changefeedccl: fix panics when min_checkpoint_frequency is 0 r=rharding6373 a=wenyihu6 Previously, we introduced the cluster setting changefeed.aggregator.flush_jitter to apply some jitter to the aggregator flush frequency. This was done to reduce the load on the coordinator by spreading out aggregator flush times. However, that PR did not account for the case where min_checkpoint_frequency is set to zero, which could cause panics due to rand.Int63(0). This patch fixes the issue by adding a check for when the frequency is zero, ensuring that jitter is not applied in such cases. Fixes: #125312 Release note (bug fix): Fixed a bug in v24.1, v23.2, and v23.1 where using changefeed.aggregator.flush_jitter with min_checkpoint_frequency set to zero could cause panics. 125350: drt: add date to roachtest_ops.log entries r=vidit-bhat a=vidit-bhat Previously, roachtest_ops.log entries show the current timestamp in hh:mm:ss without the timezone. This makes correlating logs quite tricky. This patch add date and timezone to the logs. Fixes: #125304 Release note: None Co-authored-by: Andrew Kimball <andyk@cockroachlabs.com> Co-authored-by: Wenyi Hu <wenyi@cockroachlabs.com> Co-authored-by: Vidit Bhat <vidit.bhat@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this issue
Jun 10, 2024
Previously, we introduced the cluster setting changefeed.aggregator.flush_jitter to apply some jitter to the aggregator flush frequency. This was done to reduce the load on the coordinator by spreading out aggregator flush times. However, that PR did not account for the case where min_checkpoint_frequency is set to zero, which could cause panics due to rand.Int63(0). This patch fixes the issue by adding a check for when the frequency is zero, ensuring that jitter is not applied in such cases. Fixes: #125312 Release note (bug fix): Fixed a bug in v24.1, v23.2, and v23.1 where using changefeed.aggregator.flush_jitter with min_checkpoint_frequency set to zero could cause panics.
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this issue
Jun 11, 2024
Previously, we introduced the cluster setting changefeed.aggregator.flush_jitter to apply some jitter to the aggregator flush frequency. This was done to reduce the load on the coordinator by spreading out aggregator flush times. However, that PR did not account for the case where min_checkpoint_frequency is set to zero, which could cause panics due to rand.Int63(0). This patch fixes the issue by adding a check for when the frequency is zero, ensuring that jitter is not applied in such cases. Fixes: cockroachdb#125312 Release note (bug fix): Fixed a bug in v24.1, v23.2, and v23.1 where using changefeed.aggregator.flush_jitter with min_checkpoint_frequency set to zero could cause panics.
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this issue
Jun 11, 2024
Previously, we introduced the cluster setting changefeed.aggregator.flush_jitter to apply some jitter to the aggregator flush frequency. This was done to reduce the load on the coordinator by spreading out aggregator flush times. However, that PR did not account for the case where min_checkpoint_frequency is set to zero, which could cause panics due to rand.Int63(0). This patch fixes the issue by adding a check for when the frequency is zero, ensuring that jitter is not applied in such cases. Fixes: cockroachdb#125312 Release note (bug fix): Fixed a bug in v24.1, v23.2, and v23.1 where using changefeed.aggregator.flush_jitter with min_checkpoint_frequency set to zero could cause panics.
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this issue
Jun 14, 2024
Previously, we introduced the cluster setting changefeed.aggregator.flush_jitter to apply some jitter to the aggregator flush frequency. This was done to reduce the load on the coordinator by spreading out aggregator flush times. However, that PR did not account for the case where min_checkpoint_frequency is set to zero, which could cause panics due to rand.Int63(0). This patch fixes the issue by adding a check for when the frequency is zero, ensuring that jitter is not applied in such cases. Fixes: cockroachdb#125312 Release note (bug fix): Fixed a bug in v24.1, v23.2, and v23.1 where using changefeed.aggregator.flush_jitter with min_checkpoint_frequency set to zero could cause panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
In 24.1, we introduced changefeed.aggregator.flush_jitter in #114161. Having zero min_checkpoint_frequency could cause panics here.
More details in https://github.com/cockroachlabs/support/issues/2984.
Jira issue: CRDB-39380
The text was updated successfully, but these errors were encountered: