Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamcity: failed tests on master: test/TestReplicaLeaseRejectUnknownRaftNodeID, testrace/TestReplicaLeaseRejectUnknownRaftNodeID #25599

Closed
cockroach-teamcity opened this issue May 16, 2018 · 1 comment · Fixed by #25625
Closed

teamcity: failed tests on master: test/TestReplicaLeaseRejectUnknownRaftNodeID, testrace/TestReplicaLeaseRejectUnknownRaftNodeID #25599

cockroach-teamcity opened this issue May 16, 2018 · 1 comment · Fixed by #25625
Assignees
@a-robinson
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
2.1

Comments

@cockroach-teamcity
Copy link
Member

The following tests appear to have failed:

#662218:

--- FAIL: test/TestReplicaLeaseRejectUnknownRaftNodeID (0.010s)
replica_test.go:1206: unexpected error obtaining lease for invalid store: cannot replace lease repl=(n1,s1):1 seq=1 start=0.000000000,0 exp=1.800000124,2 pro=0.900000124,3 with repl=(n2,s2):2 seq=0 start=0.900000124,0 exp=0.900000134,0: requested lease overlaps previous lease
------- Stdout: -------
I180516 22:20:34.205858 12912 storage/store.go:1440  [s1] [n1,s1]: failed initial metrics computation: [n1,s1]: system config not yet available
--- FAIL: testrace/TestReplicaLeaseRejectUnknownRaftNodeID (0.130s)

------- Stdout: -------
I180516 22:33:37.027198 12894 util/stop/stopper.go:471  quiescing; tasks left:
1      [async] gossip.infoStore: callbackreplica_test.go:1206: unexpected error obtaining lease for invalid store: cannot replace lease repl=(n1,s1):1 seq=1 start=0.000000000,0 exp=1.800000124,2 pro=0.900000124,3 with repl=(n2,s2):2 seq=0 start=0.900000124,0 exp=0.900000134,0: requested lease overlaps previous lease
------- Stdout: -------
I180516 22:20:34.205858 12912 storage/store.go:1440  [s1] [n1,s1]: failed initial metrics computation: [n1,s1]: system config not yet available

Please assign, take a look and update the issue accordingly.
@cockroach-teamcity cockroach-teamcity added this to the 2.1 milestone May 16, 2018
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels May 16, 2018
@a-robinson a-robinson self-assigned this May 17, 2018
@a-robinson a-robinson mentioned this issue May 17, 2018
Merged
@nvanbenschoten
Copy link
Member

Dup of #25568.

a-robinson added a commit to a-robinson/cockroach that referenced this issue May 17, 2018
@a-robinson
storage: Adding testing knob to disable automatic lease renewals
ca05fd1 
In order to fix the test flakes caused by automatic lease renewals

Fixes cockroachdb#25537
Fixes cockroachdb#25540
Fixes cockroachdb#25573
Fixes cockroachdb#25576
Fixes cockroachdb#25589
Fixes cockroachdb#25594
Fixes cockroachdb#25599
Fixes cockroachdb#25605
Fixes cockroachdb#25620

Release note: None
craig bot pushed a commit that referenced this issue May 17, 2018
@a-robinson @vivekmenezes @windchan7
Merge #24883 #25410 #25612 #25625
2a56696 
24883: dep: Bump grpc-go version r=a-robinson a=a-robinson

And pull in new packages -- in particular, the encoding/proto package
isn't needed for compilation but is needed at runtime.

Release note: None

---------------------

We should wait to merge this until they've cut the 1.12 release tag so that we aren't just at an arbitrary commit in their git history but I'm sending out the PR now so that I (or whoever would have done this) don't have to deal with debugging the missing encoding/proto package when it comes time to merge this.

As tested in #17370 (comment), this gives a 5-10% boost in whole-cluster throughput and improved tail latencies when run with a highly concurrent workload. It appears to have little performance effect for lower-concurrency workloads.

25410:  sql: run schema changes after CREATE TABLE in txn r=vivekmenezes a=vivekmenezes

Includes a commit from #25362 and should be reviewed after that change.

25612: util: fix `retry.WithMaxAttempts` context cancelled before run. r=windchan7 a=windchan7

If context gets cancelled right after `retry.WithMaxAttempts` runs, the function
passed to it will never gets run. Now `retry.WithMaxAttempts` will at least run
the function once otherwise an error will be returned.

Making this change because there are places such as `show_cluster_setting.go`
require the passed in function to be run at least once. Otherwise there will
be seg fault.

Fixes: #25600. 
Fixes: #25603.
Fixes: #25570. 
Fixes: #25567.
Fixes: #25566.
Fixes: #25511.
Fixes: #25485.
Release note: None

25625: storage: Adding testing knob to disable automatic lease renewals r=a-robinson a=a-robinson

In order to fix the test flakes caused by automatic lease renewals

Fixes #25537
Fixes #25540
Fixes #25568
Fixes #25573
Fixes #25576
Fixes #25589
Fixes #25594
Fixes #25599
Fixes #25605
Fixes #25620

Release note: None

Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>
Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Co-authored-by: Victor Chen <victor@cockroachlabs.com>
a-robinson added a commit to a-robinson/cockroach that referenced this issue Aug 29, 2018
@a-robinson
storage: Adding testing knob to disable automatic lease renewals
09c786a 
In order to fix the test flakes caused by automatic lease renewals

Fixes cockroachdb#25537
Fixes cockroachdb#25540
Fixes cockroachdb#25573
Fixes cockroachdb#25576
Fixes cockroachdb#25589
Fixes cockroachdb#25594
Fixes cockroachdb#25599
Fixes cockroachdb#25605
Fixes cockroachdb#25620

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-robinson a-robinson

Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

storage: Adding testing knob to disable automatic lease renewals a-robinson/cockroach
3 participants
@nvanbenschoten @a-robinson @cockroach-teamcity