storage: TestBehaviorDuringLeaseTransfer failed under stress #25573
Assignees
Labels
A-kv-distribution
Relating to rebalancing and leasing.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
Milestone
Comments
cockroach-teamcity
added
C-test-failure
|
bisected this to #25322 |
|
Parameters: Stress build found a failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=662472&tab=buildLog |
a-robinson
added a commit
to a-robinson/cockroach
that referenced
this issue
May 17, 2018
In order to fix the test flakes caused by automatic lease renewals Fixes cockroachdb#25537 Fixes cockroachdb#25540 Fixes cockroachdb#25573 Fixes cockroachdb#25576 Fixes cockroachdb#25589 Fixes cockroachdb#25594 Fixes cockroachdb#25599 Fixes cockroachdb#25605 Fixes cockroachdb#25620 Release note: None
craig bot
pushed a commit
that referenced
this issue
May 17, 2018
24883: dep: Bump grpc-go version r=a-robinson a=a-robinson And pull in new packages -- in particular, the encoding/proto package isn't needed for compilation but is needed at runtime. Release note: None --------------------- We should wait to merge this until they've cut the 1.12 release tag so that we aren't just at an arbitrary commit in their git history but I'm sending out the PR now so that I (or whoever would have done this) don't have to deal with debugging the missing encoding/proto package when it comes time to merge this. As tested in #17370 (comment), this gives a 5-10% boost in whole-cluster throughput and improved tail latencies when run with a highly concurrent workload. It appears to have little performance effect for lower-concurrency workloads. 25410: sql: run schema changes after CREATE TABLE in txn r=vivekmenezes a=vivekmenezes Includes a commit from #25362 and should be reviewed after that change. 25612: util: fix `retry.WithMaxAttempts` context cancelled before run. r=windchan7 a=windchan7 If context gets cancelled right after `retry.WithMaxAttempts` runs, the function passed to it will never gets run. Now `retry.WithMaxAttempts` will at least run the function once otherwise an error will be returned. Making this change because there are places such as `show_cluster_setting.go` require the passed in function to be run at least once. Otherwise there will be seg fault. Fixes: #25600. Fixes: #25603. Fixes: #25570. Fixes: #25567. Fixes: #25566. Fixes: #25511. Fixes: #25485. Release note: None 25625: storage: Adding testing knob to disable automatic lease renewals r=a-robinson a=a-robinson In order to fix the test flakes caused by automatic lease renewals Fixes #25537 Fixes #25540 Fixes #25568 Fixes #25573 Fixes #25576 Fixes #25589 Fixes #25594 Fixes #25599 Fixes #25605 Fixes #25620 Release note: None Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com> Co-authored-by: Victor Chen <victor@cockroachlabs.com>
a-robinson
added a commit
to a-robinson/cockroach
that referenced
this issue
Aug 29, 2018
In order to fix the test flakes caused by automatic lease renewals Fixes cockroachdb#25537 Fixes cockroachdb#25540 Fixes cockroachdb#25573 Fixes cockroachdb#25576 Fixes cockroachdb#25589 Fixes cockroachdb#25594 Fixes cockroachdb#25599 Fixes cockroachdb#25605 Fixes cockroachdb#25620 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SHA: https://github.com/cockroachdb/cockroach/commits/6f4e9b215f9a3284a39d507b3b0ddd310a0f87da
Parameters:
Stress build found a failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=660793&tab=buildLog
The text was updated successfully, but these errors were encountered: