cmd/github-post: refactor issue posting into a library

[petermattis]

See #24894

Release note: None

[cockroach-teamcity]

This change is 

[petermattis]

Hmm, this is primarily code movement, but reviewable isn't showing it as such. Let me try to structure the commits show that the actual diff shows up better. I probably won't get to this until tomorrow.

---

Review status: 0 of 5 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[tbg]

I can take another look when you've rejiggered this, but as long as you've tested it end-to-end and there aren't any substantial changes in semantics here, LGTM.

---

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

pkg/cmd/internal/issues/issues.go, line 58 at r1 (raw file):

const githubIssueBodyMaximumLength = 1<<16 - 1

func trimIssueRequestBody(message string, usedCharacters int) string {

Explain what message is with an example (I tried unsuccessfully to find out).

---

pkg/cmd/internal/issues/issues.go, line 62 at r1 (raw file):

	if m := stacktraceRE.FindStringIndex(message); m != nil {
		// We want the top stack traces plus a few lines before.

This doesn't have to be in this PR, but some of these messages can get quite long (see for example #25573).

It might be nice to use the

<details>
 <summary>Summary Goes Here</summary>
collapsed content
</details>

construct whenever a good summary is known. That would reduce the time spent scrolling vigorously while looking at test flakes.

---

Comments from Reviewable

[petermattis]

There are no semantic changes here, just reorganization of code. github-post now only cares about parsing go test output and issues.Post is what creates a github issue or adds a comment to an existing issue. This logic was previously all bundled together in github-post.

The one tiny change is that the body of the issue message now says Failed test instead of Stress build found a failed test.

---

Review status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions.

---

pkg/cmd/internal/issues/issues.go, line 58 at r1 (raw file):

Previously, tschottdorf (Tobias Schottdorf) wrote…

Explain what message is with an example (I tried unsuccessfully to find out).

Not my code. Comment added with my understanding.

---

pkg/cmd/internal/issues/issues.go, line 62 at r1 (raw file):

Previously, tschottdorf (Tobias Schottdorf) wrote…

This doesn't have to be in this PR, but some of these messages can get quite long (see for example #25573).

It might be nice to use the

<details>
 <summary>Summary Goes Here</summary>
collapsed content
</details>

construct whenever a good summary is known. That would reduce the time spent scrolling vigorously while looking at test flakes.

Agreed this would be nice. Do you know how to achieve this? I've added a TODO.

---

Comments from Reviewable

[petermattis]

bors r=tschottdorf

[craig]

Canceled

[petermattis]

bors r=tschottdorf

[craig]

Build succeeded

• GitHub CI (Cockroach)

[tbg]

🎆 🍾 I owe you one @petermattis