Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgwire: status parameter discrepancies #30692

Closed
knz opened this issue Sep 26, 2018 · 0 comments
Closed

pgwire: status parameter discrepancies #30692

knz opened this issue Sep 26, 2018 · 0 comments
Assignees
@knz
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-pgwire pgwire protocol issues. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Sep 26, 2018

When a SQL client connects the server sends a initial batch of "status parameters" which reports configuration settings valid at session initialization.

Currently CockroachDB sends constant strings for this.

This is not correct however, because the parameters should reflect any overrides made via the client own configuration parameters that were sent initially. For example application_name must pick up the value provided by the client.
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-pgwire pgwire protocol issues. labels Sep 26, 2018
@knz knz self-assigned this Sep 26, 2018
@knz knz mentioned this issue Sep 26, 2018
Merged
craig bot pushed a commit that referenced this issue Oct 5, 2018
@knz
Merge #30702
5e7d47a 
30702: sql,pgwire: fix a host of pgwire/sql interaction bugs r=knz a=knz

First commit from #30691.

Fixes #30701.
Fixes #30692.
Fixes #30693.
Fixes #30697.
Fixes #30698.
Fixes #30703.
Informs #30717.

With special thanks to @benesch for asking me to poke at this.

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig craig bot closed this as completed in #30702 Oct 5, 2018
@knz knz mentioned this issue Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-pgwire pgwire protocol issues. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knz