sql: pg_settings doesn't report unit column properly

[knz]

The output of SHOW [SESSION] and pg_settings is currently inconsistent / incompatible with postgres.

Postgres:

kena=# select name,setting,unit from pg_settings where name='statement_timeout';
       name        | setting | unit
-------------------+---------+------
 statement_timeout | 0       | ms
(1 row)

kena=# show statement_timeout;
 statement_timeout
-------------------
 0
(1 row)

CockroachDB:

root@127.0.0.1:29726/defaultdb> select name,setting,unit from pg_settings where name='statement_timeout';
        name        | setting | unit
+-------------------+---------+------+
  statement_timeout | 0      | NULL
(1 row)

Time: 653.938µs

root@127.0.0.1:29726/defaultdb> show statement_timeout;
  statement_timeout
+-------------------+
  0s
(1 row)

Time: 472.901µs

In other words: CockroachDB doesn't report the unit column.

Jira issue: CRDB-4823

[github-actions]

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

[knz]

still exists in 21.1

[github-actions]

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

[knz]

The unit is still missing in cockroachdb.