Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec: mismatched batch width and schema length on fakedist config #38970

Closed
yuzefovich opened this issue Jul 18, 2019 · 1 comment · Fixed by #38983
Closed

exec: mismatched batch width and schema length on fakedist config #38970

yuzefovich opened this issue Jul 18, 2019 · 1 comment · Fixed by #38983
Assignees
Labels
A-sql-vec SQL vectorized engine C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@yuzefovich
Copy link
Member

I added the following configs to logic.go:

{name: "fakedist-vec", numNodes: 3, useFakeSpanResolver: true, overrideDistSQLMode: "on", overrideOptimizerMode: "off", overrideExpVectorize: "on"},
{name: "fakedist-opt-vec", numNodes: 3, useFakeSpanResolver: true, overrideDistSQLMode: "on", overrideOptimizerMode: "on", overrideAutoStats: "false", overrideExpVectorize: "on"},

and the following logic test fails on master:

# LogicTest: fakedist-vec fakedist-opt-vec

statement ok
CREATE TABLE abc (a INT PRIMARY KEY, b INT, c INT)

statement ok
INSERT INTO abc VALUES (1, 2, 3)

query I colnames
SELECT a+b+c AS foo FROM abc
----
foo
6

Note that it fails pretty reliably, but sometimes it's either of the configs, sometimes it's both (I haven't seen it succeed in 10 or so runs).

@yuzefovich yuzefovich added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-vec SQL vectorized engine labels Jul 18, 2019
@yuzefovich
Copy link
Member Author

Assigning to @asubiotto since you expressed an interest in this issue in #38920.

craig bot pushed a commit that referenced this issue Jul 19, 2019
38983: exec: fix output types for projections r=jordanlewis a=jordanlewis

Previously, the output type of a projection was always set to the data
type of its input. This doesn't work for boolean projections like
eqIntIntOp, obviously. This wasn't failing tests because the final
materializer ignores the output column types, and we never fed boolean
projections into things that weren't the final materializers. This will
be tested going forward via distributed plans as well.

Closes #38970.

Release note: None

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig craig bot closed this as completed in #38983 Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-vec SQL vectorized engine C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants