exec: fix output types for projections #38983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the output type of a projection was always set to the data type of its input. This doesn't work for boolean projections like eqIntIntOp, obviously. This wasn't failing tests because the final materializer ignores the output column types, and we never fed boolean projections into things that weren't the final materializers. This will be tested going forward via distributed plans as well. Release note: None
|
This change is |
yuzefovich
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Glad we got to the bottom of this!
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 19, 2019
38983: exec: fix output types for projections r=jordanlewis a=jordanlewis Previously, the output type of a projection was always set to the data type of its input. This doesn't work for boolean projections like eqIntIntOp, obviously. This wasn't failing tests because the final materializer ignores the output column types, and we never fed boolean projections into things that weren't the final materializers. This will be tested going forward via distributed plans as well. Closes #38970. Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the output type of a projection was always set to the data
type of its input. This doesn't work for boolean projections like
eqIntIntOp, obviously. This wasn't failing tests because the final
materializer ignores the output column types, and we never fed boolean
projections into things that weren't the final materializers. This will
be tested going forward via distributed plans as well.
Closes #38970.
Release note: None