Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: bad error for comment on claiming that the feature is not implemented #40713

Closed
andreimatei opened this issue Sep 12, 2019 · 0 comments · Fixed by #40943
Closed

sql: bad error for comment on claiming that the feature is not implemented #40713

andreimatei opened this issue Sep 12, 2019 · 0 comments · Fixed by #40943
Assignees
@arulajmani
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@andreimatei
Copy link
Contributor

andreimatei commented Sep 12, 2019 •
edited
Loading

I messed up the syntax (string quotes) and look what happened.

root@:26257/defaultdb> comment on column t.x is "aaaa";
invalid syntax: statement ignored: at or near "aaaa": syntax error: unimplemented: this syntax
DETAIL: source SQL:
comment on column t.x is "aaaa"
                         ^
HINT: You have attempted to use a feature that is not yet implemented.
See: https://github.com/cockroachdb/cockroach/issues/19472



root@:26257/defaultdb> comment on column t.x is 'aaaa';
COMMENT ON COLUMN
@andreimatei andreimatei added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3 Medium-low impact: incurs increased costs for some users (incl lower avail, recoverable bad data) labels Sep 12, 2019
@jordanlewis jordanlewis removed the S-3 Medium-low impact: incurs increased costs for some users (incl lower avail, recoverable bad data) label Sep 12, 2019
@arulajmani arulajmani mentioned this issue Sep 20, 2019
Merged
craig bot pushed a commit that referenced this issue Sep 20, 2019
@arulajmani @jordanlewis
Merge #40943 #40944
1adb5d7 
40943: sql: remove unimplemented error message from COMMENT ON statement r=arulajmani a=arulajmani

Any syntax error while using the COMMENT ON statement returns an error
referencing #19472. With #19472 closed, we should no longer reference
it when the syntax is wrong.

Fixes #40713

Release note: None

Release Justification: Very minor change

40944: roachtest: tpcc-max had too low of a timeout r=jordanlewis a=jordanlewis

It's supposed to run for 6 days, but used the default timeout of 10
hours.

Closes #38558.

Release note: None
Release justification: test-only change

Co-authored-by: Arul Ajmani <arula@cockroachlabs.com>
Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig craig bot closed this as completed in 7979cf1 Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arulajmani arulajmani

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: remove unimplemented error message from COMMENT ON statement arulajmani/cockroach
3 participants
@jordanlewis @andreimatei @arulajmani