roachtest: tpcc-max had too low of a timeout #40944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's supposed to run for 6 days, but used the default timeout of 10 hours. Release note: None Release justification: test-only change
|
This change is |
andreimatei
reviewed
Sep 20, 2019
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @nvanbenschoten)
|
Just make sure this guy is not ran nightly.
…On Fri, Sep 20, 2019 at 2:04 PM Andrei Matei ***@***.***> wrote:
***@***.**** commented on this pull request.
LGTM
*Reviewable
<https://reviewable.io/reviews/cockroachdb/cockroach/40944#-:-LpEpySw2exTM32tFyLS:bb6ywmx>*
status: [image:
] complete! 0 of 0 LGTMs obtained (waiting on
@andreimatei <https://github.com/andreimatei> and @nvanbenschoten
<https://github.com/nvanbenschoten>)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#40944?email_source=notifications&email_token=AAC4C4MD6XWSJUQZ5J4VBK3QKUGB3A5CNFSM4IYZYY7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFOSCJA#pullrequestreview-291316004>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC4C4NKNP4LRVX3K427SM3QKUGB3ANCNFSM4IYZYY7A>
.
|
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 20, 2019
40943: sql: remove unimplemented error message from COMMENT ON statement r=arulajmani a=arulajmani Any syntax error while using the COMMENT ON statement returns an error referencing #19472. With #19472 closed, we should no longer reference it when the syntax is wrong. Fixes #40713 Release note: None Release Justification: Very minor change 40944: roachtest: tpcc-max had too low of a timeout r=jordanlewis a=jordanlewis It's supposed to run for 6 days, but used the default timeout of 10 hours. Closes #38558. Release note: None Release justification: test-only change Co-authored-by: Arul Ajmani <arula@cockroachlabs.com> Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's supposed to run for 6 days, but used the default timeout of 10
hours.
Closes #38558.
Release note: None
Release justification: test-only change