Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add a notice for async jobs in alter primary key #45730

Closed
rohany opened this issue Mar 4, 2020 · 0 comments · Fixed by #45752
Closed

sql: add a notice for async jobs in alter primary key #45730

rohany opened this issue Mar 4, 2020 · 0 comments · Fixed by #45752
Assignees
@rohany

Comments

@rohany
Copy link
Contributor

rohany commented Mar 4, 2020

Mentioned in #45150
@rohany rohany self-assigned this Mar 4, 2020
@rohany rohany mentioned this issue Mar 5, 2020
Merged
craig bot pushed a commit that referenced this issue Mar 5, 2020
@rafiss @jordanlewis
@andreimatei @rohany
Merge #45667 #45726 #45737 #45738 #45752
e4d0a0e 
45667: ui: Refactor redux connect for enqueue ranges r=nathanstilwell a=nathanstilwell

Moving `handleEnqueueRange` from Redux connect to a method in the component as the data seems useless in the state and doesn't dispatch an action.

It seems like the GPRC promise wasn't getting handled by either the [Thunk](https://github.com/reduxjs/redux-thunk) or [Saga](https://github.com/redux-saga/redux-saga) middleware and was confusing Redux as with a [Promise](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise) instead of [an action](https://redux.js.org/basics/actions/).

I'm also increasing the request timeout time on the GPRC request to an hour to ensure completion of tasks.

fixes #44948, #42888

45726: roachtest: use more memory for django roachtest r=rafiss a=rafiss

It is currently running into OOM issues. This should fix it until we can
reduce memory usage.

Also, fix the repo name when getting the latest django-cockroachdb
release.

Release note: None

45737: execgen: try not to touch .eg.go files r=jordanlewis a=jordanlewis

This changes the Makefile to output .eg.go output to a tmp file before
actually editing .eg.go files, to prevent build churn.

Release note: None

45738: roachpb: make the ignored seq num list copy on write r=andreimatei a=andreimatei

Unfortunately the RaceTransport doesn't allow any data referenced by a
Transaction proto to be mutated. This patch makes updates to the ignored
seq nums conform.
The RaceTransport wants to prevent the server from doing such mutations.
In this case it's the client that does the mutations, which should be
allowed, but the implementation of this testing tool casts a wide net.

Release note: None

45752: sql: add a notice to primary key changes about async jobs r=otan a=rohany

Fixes #45730.

Release note: None

Co-authored-by: Nathan Stilwell <nathanstilwell@cockroachlabs.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
@craig craig bot closed this as completed in de9786a Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohany rohany

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add a notice to primary key changes about async jobs rohany/cockroach
1 participant
@rohany