sql: add a notice to primary key changes about async jobs #45752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
you can add a test to pkg/cli/interactive_tests/test_notice.tcl with expect -f pkg/cli/interactive_tests/test_notice.tcl ./cockroach (warning: adds new directories and files - nothing git clean -fd won't fix) if you were inclined.
i do wonder if we should just blanket add notices for all things scheduling a schema job.
|
Might as well add a test. cc @awoods187 is already putting together a document of all the places we should add notices |
Fixes cockroachdb#45730. Release note: None
|
bors r=otan |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45730.
Release note: None