Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: something is off with EXECGEN_TARGETS and logictest-bins #49676

Closed
yuzefovich opened this issue May 29, 2020 · 1 comment · Fixed by #49696
Closed

build: something is off with EXECGEN_TARGETS and logictest-bins #49676

yuzefovich opened this issue May 29, 2020 · 1 comment · Fixed by #49696
Assignees
@petermattis
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@yuzefovich
Copy link
Member

Here is a repro of some weird behavior of logic test binary:

git reset --hard 885b0ed7eb8a10ecb88566d5fb337c3a68fd1273

# This succeeds.
make clean && make testbaselogic FILES=vectorize_types

git reset --hard HEAD^

# This fails.
make testbaselogic FILES=vectorize_types

The failure is

EXECGEN pkg/sql/colexec/hashtable_distinct.eg.go
EXECGEN pkg/sql/colexec/hashtable_full.eg.go
ERROR: unrecognized filename: hashtable_full.eg.go
ERROR: unrecognized filename: hashtable_distinct.eg.go
make: *** [pkg/sql/colexec/hashtable_distinct.eg.go] Error 1
make: *** Waiting for unfinished jobs....
make: *** [pkg/sql/colexec/hashtable_full.eg.go] Error 1

Note that the commit in question introduced these two EXECGEN_TARGETS and removed another one (namely, it removed hashtable.eg.go and added hashtable_full.eg.go and hashtable_distinct.eg.go).
@yuzefovich yuzefovich added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system labels May 29, 2020
@petermattis
Copy link
Collaborator

Thanks for the repro steps, @yuzefovich. I'm taking a look.

@petermattis petermattis mentioned this issue May 29, 2020
Merged
craig bot pushed a commit that referenced this issue May 29, 2020
@petermattis
Merge #49696
6740c94 
49696: Makefile: fix handling of non-existent *.eg.go files r=petermattis a=petermattis

When a `bin/*.d` file references an `*.eg.go` file, that file was
required to exist or be buildable by the Makefile. Any commit which
removed a `*.eg.go` file would violate this requirement causing the
build to fail until the offending `bin/*.d` file was removed. In order
to prevent this badness, a catchall `%.eg.go` rule is added which will
force the target dependent on the `bin/%.d` file to be rebuilt.

Fixes #49676

Release note: None

Co-authored-by: Peter Mattis <petermattis@gmail.com>
@craig craig bot closed this as completed in 5868836 May 29, 2020
jbowens pushed a commit to jbowens/cockroach that referenced this issue Jun 1, 2020
@petermattis @jbowens
Makefile: fix handling of non-existent *.eg.go files
d4ed2f7 
When a `bin/*.d` file references an `*.eg.go` file, that file was
required to exist or be buildable by the Makefile. Any commit which
removed a `*.eg.go` file would violate this requirement causing the
build to fail until the offending `bin/*.d` file was removed. In order
to prevent this badness, a catchall `%.eg.go` rule is added which will
force the target dependent on the `bin/%.d` file to be rebuilt.

Fixes cockroachdb#49676

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermattis petermattis

Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile: fix handling of non-existent *.eg.go files petermattis/cockroach
2 participants
@yuzefovich @petermattis