Makefile: fix handling of non-existent *.eg.go files #49696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `bin/*.d` file references an `*.eg.go` file, that file was required to exist or be buildable by the Makefile. Any commit which removed a `*.eg.go` file would violate this requirement causing the build to fail until the offending `bin/*.d` file was removed. In order to prevent this badness, a catchall `%.eg.go` rule is added which will force the target dependent on the `bin/%.d` file to be rebuilt. Fixes cockroachdb#49676 Release note: None
|
This change is |
|
Cc @yuzefovich |
|
TFTR! bors r+ |
Build succeeded |
|
Thanks! |
|
Thanks @petermattis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
bin/*.dfile references an*.eg.gofile, that file wasrequired to exist or be buildable by the Makefile. Any commit which
removed a
*.eg.gofile would violate this requirement causing thebuild to fail until the offending
bin/*.dfile was removed. In orderto prevent this badness, a catchall
%.eg.gorule is added which willforce the target dependent on the
bin/%.dfile to be rebuilt.Fixes #49676
Release note: None