sql: allow old enum value '1' for sql.defaults.vectorize #133281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
reviewed
Oct 23, 2024
mw5h
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @spilchen)
michae2
added
backport-24.2.x
Fixes: cockroachdb#133278 Release note (bug fix): This commit fixes a bug which causes new connections to fail with the following error after upgrading to v24.2: ``` ERROR: invalid value for parameter "vectorize": "unknown(1)" SQLSTATE: 22023 HINT: Available values: off,on,experimental_always ``` In order to hit this bug, the cluster must have: 1. been on version v21.1 at some point in the past 2. run `SET CLUSTER SETTING sql.defaults.vectorize = 'on';` on v21.1 3. not set sql.defaults.vectorize after upgrading past v21.1 4. upgraded all the way to v24.2 The conditions required for this bug can be detected using: ``` SELECT * FROM system.settings WHERE name = 'sql.defaults.vectorize'; ``` If the value is '1', the following statement should be run to fix it before upgrading to v24.2: ``` RESET CLUSTER SETTING sql.defaults.vectorize; ``` This commit fixes the bug by making '1' a legal value for sql.defaults.vectorize again (mapping to 'on').
|
TFTRs! bors r=mw5h |
10 tasks
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #133278
Release note (bug fix): This commit fixes a bug which causes new connections to fail with the following error after upgrading to v24.2:
In order to hit this bug, the cluster must have:
SET CLUSTER SETTING sql.defaults.vectorize = 'on';on v21.1The conditions required for this bug can be detected using:
If the value is '1', the following statement should be run to fix it before upgrading to v24.2:
This commit fixes the bug by making '1' a legal value for sql.defaults.vectorize again (mapping to 'on').