Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sql/logictest/tests/local-vec-off/local-vec-off_test: TestLogic_system failed #133429

Closed
cockroach-teamcity opened this issue Oct 25, 2024 · 3 comments · Fixed by #133593
Closed

pkg/sql/logictest/tests/local-vec-off/local-vec-off_test: TestLogic_system failed #133429

cockroach-teamcity opened this issue Oct 25, 2024 · 3 comments · Fixed by #133593
Assignees
@michae2
Labels
branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 25, 2024 •
edited by cockroach-jira-scripts
Loading

pkg/sql/logictest/tests/local-vec-off/local-vec-off_test.TestLogic_system failed on release-24.3 @ 047a8e99eb7a35e3f13ecf6b113f1965f206e3b9:

=== RUN   TestLogic_system
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestLogic_system2637775106
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:139: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logic.go:3043: 
         
        /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/bin/pkg/sql/logictest/tests/local-vec-off/local-vec-off_test_/local-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/system:1443: SHOW CLUSTER SETTING sql.defaults.vectorize
        expected:
            on
            
        but found (query options: "") :
            off
            
[06:06:59] --- done: /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/bin/pkg/sql/logictest/tests/local-vec-off/local-vec-off_test_/local-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/system with config local-vec-off: 75 tests, 1 failures
    logic.go:4229: 
        /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/bin/pkg/sql/logictest/tests/local-vec-off/local-vec-off_test_/local-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/system:1448: error while processing
    logic.go:4229: /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/bin/pkg/sql/logictest/tests/local-vec-off/local-vec-off_test_/local-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/system:1448: too many errors encountered, skipping the rest of the input
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestLogic_system2637775106
--- FAIL: TestLogic_system (1.39s)

Parameters:

  • attempt=1
  • run=7
  • shard=45
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

Jira issue: CRDB-43602
@cockroach-teamcity cockroach-teamcity added branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Oct 25, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Oct 25, 2024
@github-actions GitHub Actions
Copy link

pkg/sql/logictest/tests/local-vec-off/local-vec-off_test.TestLogic_system failed on release-24.3 @ 35559e1dba8ff00d40bfff27d1ff3bbcad708935:

=== RUN   TestLogic_system
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestLogic_system1920086449
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:139: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
[15:13:40] setting distsql_workmem='65834B';
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logictestbase.go:550: statement/query skipped with reason: unsupported configuration local-vec-off, statement/query only supports 3node-tenant-default-configs (no issue given)
    logic.go:3043: 
         
        /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/bin/pkg/sql/logictest/tests/local-vec-off/local-vec-off_test_/local-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/system:1443: SHOW CLUSTER SETTING sql.defaults.vectorize
        expected:
            on
            
        but found (query options: "") :
            off
            
[15:13:41] --- done: /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/bin/pkg/sql/logictest/tests/local-vec-off/local-vec-off_test_/local-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/system with config local-vec-off: 75 tests, 1 failures
    logic.go:4229: 
        /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/bin/pkg/sql/logictest/tests/local-vec-off/local-vec-off_test_/local-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/system:1448: error while processing
    logic.go:4229: /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/bin/pkg/sql/logictest/tests/local-vec-off/local-vec-off_test_/local-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/system:1448: too many errors encountered, skipping the rest of the input
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestLogic_system1920086449
--- FAIL: TestLogic_system (1.24s)

Parameters:

  • attempt=1
  • run=1
  • shard=45
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@michae2 michae2 self-assigned this Oct 28, 2024
@michae2 michae2 moved this from Triage to Active in SQL Queries Oct 28, 2024
@michae2
Copy link
Collaborator

michae2 commented Oct 28, 2024

This is probably fallout from #133281

@michae2 michae2 removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Oct 28, 2024
@michae2 michae2 mentioned this issue Oct 28, 2024
Merged
@mgartner mgartner mentioned this issue Oct 29, 2024
Closed
craig bot pushed a commit that referenced this issue Oct 29, 2024
@mgartner @xinhaoz
@michae2 @rickystewart
Merge #133241 #133483 #133593 #133711
d3409d8 
133241: opt: relax max stack size in test for stack overflow r=mgartner a=mgartner

This commit relaxes the maximum Go stack size in bytes for a test added
in #132701 from 50KB to 125KB. The very low max stack size was causing
stack overflows to occur in unrelated functions, like parsing, in some
nightly tests. I'm hoping that more than doubling this will eliminate
the flakes.

Fixes #133212

Release note: None


133483: ui: cleanup useNodeStatuses usages r=xinhaoz a=xinhaoz

This commit cleans up the useNodeStatuses hook. The raw data from the response is no longer returned from the hook.  Instead, callers must use the transformed data.

Epic: none

Release note: None

133593: logic_test: add retry to SHOW CLUSTER SETTING r=mgartner a=michae2

The cluster setting system is not synchronous; sometimes there is a delay between writing to system.settings and seeing the change in SHOW CLUSTER SETTING output.

Fixes: #133429

Release note: None

133711: pebble_nightly_metamorphic: show sizes of artifacts r=jlinder a=rickystewart

We're seeing OOM's when trying to upload artifacts. Print out the sizes so we can validate our assumption the artifacts are very large.

Epic: none
Release note: None

Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
Co-authored-by: Xin Hao Zhang <xzhang@cockroachlabs.com>
Co-authored-by: Michael Erickson <michae2@cockroachlabs.com>
Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
@craig craig bot closed this as completed in bd18e4c Oct 29, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Oct 29, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Oct 29, 2024

Based on the specified backports for linked PR #133593, I applied the following new label(s) to this issue: branch-release-24.2. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 label Oct 29, 2024
blathers-crl bot pushed a commit that referenced this issue Oct 29, 2024
@michae2
logic_test: add retry to SHOW CLUSTER SETTING
5946349 
The cluster setting system is not synchronous; sometimes there is a
delay between writing to system.settings and seeing the change in SHOW
CLUSTER SETTING output.

Fixes: #133429

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Oct 29, 2024
Merged
blathers-crl bot pushed a commit that referenced this issue Oct 29, 2024
@michae2
logic_test: add retry to SHOW CLUSTER SETTING
a406834 
The cluster setting system is not synchronous; sometimes there is a
delay between writing to system.settings and seeing the change in SHOW
CLUSTER SETTING output.

Fixes: #133429

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Oct 29, 2024
Merged
blathers-crl bot pushed a commit that referenced this issue Nov 6, 2024
@michae2
logic_test: add retry to SHOW CLUSTER SETTING
540a452 
The cluster setting system is not synchronous; sometimes there is a
delay between writing to system.settings and seeing the change in SHOW
CLUSTER SETTING output.

Fixes: #133429

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michae2 michae2

Labels
branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

logic_test: add retry to SHOW CLUSTER SETTING michae2/cockroach
2 participants
@cockroach-teamcity @michae2