opt: relax max stack size in test for stack overflow #133241
Conversation
|
This change is |
mgartner
added
backport-23.1.x
|
Friendly ping @mw5h :) |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
-- commits line 5 at r1:
I think you mean 125KB.
pkg/sql/opt/xform/testdata/rules/select line 2823 at r1 (raw file):
# `IN` list below huge - triggering a stack overflow with Go's default max stack # size requires a list of ~1.6 million elements. opt max-stack=125KB format=hide-all
Do we not care about powers of two in Go?
This commit relaxes the maximum Go stack size in bytes for a test added in cockroachdb#132701 from 50KB to 125KB. The very low max stack size was causing stack overflows to occur in unrelated functions, like parsing, in some nightly tests. I'm hoping that more than doubling this will eliminate the flakes. Fixes cockroachdb#133212 Release note: None
mgartner
force-pushed
the
133212-relax-max-stack-test
branch
from
7cb0ecb to
b5b7606
Compare
There was a problem hiding this comment.
Reviewable status:
Previously, mw5h (Matt White) wrote…
I think you mean 125KB.
Done.
pkg/sql/opt/xform/testdata/rules/select line 2823 at r1 (raw file):
Previously, mw5h (Matt White) wrote…
Do we not care about powers of two in Go?
What were you thinking? I don't know why using a power of 2 would be relevant here.
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/xform/testdata/rules/select line 2823 at r1 (raw file):
Previously, mgartner (Marcus Gartner) wrote…
What were you thinking? I don't know why using a power of 2 would be relevant here.
It's probably not. In a runtime where the stack size is static, I'd want want that so that my stacks are all cache & page aligned without wastage.
I see. This setting only controls the size limit of stacks in bytes, AFAIK. bors r+ |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #133212: branch-release-23.1, branch-release-23.2, branch-release-24.1, branch-release-24.3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
blathers backport release-23.2.15-rc |
|
blathers backport release-23.1.29-rc |
The `max-stack` opt tester option now run the test command in a separate goroutine. A fresh stack makes tests using this setting more reliable. It also reverts the increase of `max-stack` of a test from cockroachdb#133241 because it is no longer necessary. Release note: None
The `max-stack` opt tester option now run the test command in a separate goroutine. A fresh stack makes tests using this setting more reliable. It also reverts the increase of `max-stack` of a test from cockroachdb#133241 because it is no longer necessary. Release note: None
This commit relaxes the maximum Go stack size in bytes for a test added
in #132701 from 50KB to 125KB. The very low max stack size was causing
stack overflows to occur in unrelated functions, like parsing, in some
nightly tests. I'm hoping that more than doubling this will eliminate
the flakes.
Fixes #133212
Release note: None