opt: prevent stack overflow when deriving computed column filters

[mgartner]

opt: add max-stack opttest option

This commit adds the max-stack option for opttests, allowing tests to
alter the maximum stack size for the goroutine that optimizes the query.

Release note: None

opt: prevent stack overflow when deriving computed column filters

Previously, a filter of the form col IN (elem0, elem1, ..., elemN)
could result in a stack overflow in the optimizer when N is very
large, e.g., 1.6 million or more . The problem would occur when trying
to derive constraints for indexes on computed column, specifically when
those computed columns are dependent on the column in the filter, e.g.,
col in the example.

The current implementation builds an OrExpr tree with depth equal to
the length of the IN list. It then constructs a FiltersItem with the
OrExpr tree as the condition, causing logical properties to be built
for the expression. When building logical properties, the OrExpr tree
is traversed recursively, which causes the stack to overflow when the
tree is very deep.

Now, an OrExpr tree is never built. Instead,
CombineComputedColFilters returns a slice of ScalarExprs that
represents a disjunction of expressions. This effectively eliminates the
possibility of stack overflows in code that recursively traverses the
derived expressions. It also simplified the logic.

Fixes #132669

Release note (bug fix): A bug in the query optimizer which could cause
CockroachDB nodes to crash in rare cases has been fixed. The bug could
occur when a query contains a filter in the form
col IN (elem0, elem1, ..., elemN) only when N is very large, e.g.,
1.6+ million, and when col exists in a hash-sharded index or exists a
table with an indexed, computed column dependent on col.

[cockroach-teamcity]

This change is 

[DrewKimball]

Elegant fix. Nice work!

Reviewed 2 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mw5h)

[mgartner]

TFTR!

bors r+

[craig]

Build succeeded:

• local_roachtest
• docker_image_amd64
• unit_tests
• linux_amd64_fips_build
• macos_arm64_build
• check_generated_code
• windows_build
• examples_orms
• linux_arm64_build
• local_roachtest_fips
• lint
• linux_amd64_build
• macos_amd64_build
• acceptance

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 56d6b22 to blathers/backport-release-23.1-132701: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

---

error creating merge commit from a3d27e8 to blathers/backport-release-23.2-132701: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.

---

error creating merge commit from a3d27e8 to blathers/backport-release-24.1-132701: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}