release-24.2.5-rc: opt: make max-stack
opt tester option more reliable
#134468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #134313.
/cc @cockroachdb/release
The
max-stack
opt tester option now runs the test command in aseparate goroutine. A fresh stack makes tests using this setting more
reliable.
It also decreases the
max-stack
of the original test that motivatedthe
max-stack
option (see #132701) to 100KB, between 65KB in which thetest fails after the fix in #132701 and 135KB in which the test fails
before the fix.
Finally, the test has been disabled under
race
builds which increasethe size of stack frames and would cause this test to fail.
Epic: None
Release note: None
Release justification: Test-only change.