-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1.29-rc: opt: make max-stack
opt tester option more reliable
#134439
release-23.1.29-rc: opt: make max-stack
opt tester option more reliable
#134439
Conversation
The `max-stack` opt tester option now runs the test command in a separate goroutine. A fresh stack makes tests using this setting more reliable. It also decreases the `max-stack` of the original test that motivated the `max-stack` option (see #132701) to 100KB, between 65KB in which the test fails after the fix in #132701 and 135KB in which the test fails before the fix. Finally, the test has been disabled under `race` builds which increase the size of stack frames and would cause this test to fail. Release note: None
8ca4dcd
to
535ad0e
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @mw5h)
…ort-release-23.1.29-rc-134313 release-23.1.29-rc: opt: make `max-stack` opt tester option more reliable (cockroachdb#134439) Co-Authored-By: Marcus Gartner <marcus@cockroachlabs.com>
Backport 1/1 commits from #134313 on behalf of @mgartner.
/cc @cockroachdb/release
The
max-stack
opt tester option now runs the test command in aseparate goroutine. A fresh stack makes tests using this setting more
reliable.
It also decreases the
max-stack
of the original test that motivatedthe
max-stack
option (see #132701) to 100KB, between 65KB in which thetest fails after the fix in #132701 and 135KB in which the test fails
before the fix.
Finally, the test has been disabled under
race
builds which increasethe size of stack frames and would cause this test to fail.
Epic: None
Release note: None
Release justification: Test-only change.