-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2.15-rc: opt: relax max stack size in test for stack overflow #133910
release-23.2.15-rc: opt: relax max stack size in test for stack overflow #133910
Conversation
This commit relaxes the maximum Go stack size in bytes for a test added in #132701 from 50KB to 125KB. The very low max stack size was causing stack overflows to occur in unrelated functions, like parsing, in some nightly tests. I'm hoping that more than doubling this will eliminate the flakes. Fixes #133212 Release note: None
c47a641
to
79d1a71
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @mgartner and @mw5h)
Backport 1/1 commits from #133241 on behalf of @mgartner.
/cc @cockroachdb/release
This commit relaxes the maximum Go stack size in bytes for a test added
in #132701 from 50KB to 125KB. The very low max stack size was causing
stack overflows to occur in unrelated functions, like parsing, in some
nightly tests. I'm hoping that more than doubling this will eliminate
the flakes.
Fixes #133212
Release note: None
Release justification: Test-only change.