Skip to content

Comments

roachtest: fix bench roachtests failing with validation when using json#135540

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
sambhav-jain-16:CRDB-41992
Nov 18, 2024
Merged

roachtest: fix bench roachtests failing with validation when using json#135540
craig[bot] merged 1 commit intocockroachdb:masterfrom
sambhav-jain-16:CRDB-41992

Conversation

@sambhav-jain-16
Copy link
Contributor

@sambhav-jain-16 sambhav-jain-16 commented Nov 18, 2024

The roachtests starting failing with validation errors Error: error creating metrics exporter: file path must end with .json after this PR
was merged #133035 path
defined in GetWorkloadHistogramArgs was jumbled.

Also there was an error in
#135239.

This change intends to fix all the errors.

Epic: none

Release note: None

@sambhav-jain-16 sambhav-jain-16 requested a review from a team as a code owner November 18, 2024 04:02
@sambhav-jain-16 sambhav-jain-16 requested review from nameisbhaskar and vidit-bhat and removed request for a team November 18, 2024 04:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@srosenberg
Copy link
Member

The roachtests starting failing with validation errors Error: error creating metrics exporter: file path must end with .json. The path defined in GetWorkloadHistogramArgs was jumbled. This change intends to fix that.

Can you update your commit message to reference the aforementioned PR.

@sambhav-jain-16
Copy link
Contributor Author

The roachtests starting failing with validation errors Error: error creating metrics exporter: file path must end with .json. The path defined in GetWorkloadHistogramArgs was jumbled. This change intends to fix that.

Can you update your commit message to reference the aforementioned PR.

Done

@srosenberg srosenberg self-requested a review November 18, 2024 04:17
The roachtests starting failing with validation errors `Error: error
creating metrics exporter: file path must end with .json` after this PR
was merged cockroachdb#133035 path
defined in `GetWorkloadHistogramArgs` was jumbled.

Also there was an error in
cockroachdb#135239.

This change intends to fix all the errors.

Epic: none

Release note: None
@sambhav-jain-16
Copy link
Contributor Author

sambhav-jain-16 commented Nov 18, 2024

There were more errors in a different PR that I merged in the scripts #135239 (The build succeeded when I tested in my branch, not sure what happened suddenly).
I have reverted that commit in this PR to unblock the nightlies.

Test run: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/17810249?showLog=17810249_5654_274.5012.5448&hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&logView=linear&expandBuildTestsSection=true

@sambhav-jain-16
Copy link
Contributor Author

There were more errors in a different PR that I merged in the scripts #135239 (The build succeeded when I tested in my branch, not sure what happened suddenly). I have reverted that commit in this PR to unblock the nightlies.

Test run: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/17810249?showLog=17810249_5654_274.5012.5448&hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&logView=linear&expandBuildTestsSection=true

Test run passed.
There are 3 failures due to pre-emption. Merging this PR.

@sambhav-jain-16
Copy link
Contributor Author

TFTR!

bors r=@srosenberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants