roachtest: fix bench roachtests failing with validation when using json#135540
roachtest: fix bench roachtests failing with validation when using json#135540craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
3de7728 to
0141c4f
Compare
|
Triggered a test run: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/17810012?buildTab=overview&hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true to verify the changes are working fine. The above step failed due to another error: |
Can you update your commit message to reference the aforementioned PR. |
0141c4f to
666ce06
Compare
Done |
666ce06 to
4322bb7
Compare
4322bb7 to
20f56b3
Compare
The roachtests starting failing with validation errors `Error: error creating metrics exporter: file path must end with .json` after this PR was merged cockroachdb#133035 path defined in `GetWorkloadHistogramArgs` was jumbled. Also there was an error in cockroachdb#135239. This change intends to fix all the errors. Epic: none Release note: None
20f56b3 to
089a644
Compare
|
There were more errors in a different PR that I merged in the scripts #135239 (The build succeeded when I tested in my branch, not sure what happened suddenly). |
Test run passed. |
|
TFTR! bors r=@srosenberg |
The roachtests starting failing with validation errors
Error: error creating metrics exporter: file path must end with .jsonafter this PRwas merged #133035 path
defined in
GetWorkloadHistogramArgswas jumbled.Also there was an error in
#135239.
This change intends to fix all the errors.
Epic: none
Release note: None