build/teamcity: add changes to enable openmetrics in nightly roachtests#135239
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 17, 2024
Merged
build/teamcity: add changes to enable openmetrics in nightly roachtests#135239craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
sambhav-jain-16
force-pushed
the
CRDB-41992
branch
from
8c3b4d2 to
b2d2e55
Compare
cockroachdb#133035 added changes to the `roachtest` binary to emit openmetrics from benchmarks. This change is intended for nightlies to be able to pass on relevant flags and buckets to export openmetrics Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None
sambhav-jain-16
force-pushed
the
CRDB-41992
branch
from
b2d2e55 to
6f5314b
Compare
Contributor
Author
|
TFTR! bors r=@nameisbhaskar |
Contributor
sambhav-jain-16
added a commit
to sambhav-jain-16/cockroach
that referenced
this pull request
Nov 18, 2024
The roachtests starting failing with validation errors `Error: error creating metrics exporter: file path must end with .json` after this PR was merged cockroachdb#133035 path defined in `GetWorkloadHistogramArgs` was jumbled. Also there was an error in cockroachdb#135239. This change intends to fix all the errors. Epic: none Release note: None
craig bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
135540: roachtest: fix bench roachtests failing with validation when using json r=srosenberg a=sambhav-jain-16 The roachtests starting failing with validation errors `Error: error creating metrics exporter: file path must end with .json` after this PR was merged #133035 path defined in `GetWorkloadHistogramArgs` was jumbled. Also there was an error in #135239. This change intends to fix all the errors. Epic: none Release note: None Co-authored-by: Sambhav Jain <sambhav.jain@cockroachlabs.com>
sambhav-jain-16
added a commit
to sambhav-jain-16/cockroach
that referenced
this pull request
Nov 18, 2024
There was a regression in cockroachdb#135239. The change was reverted and this PR aims to fix the regressions Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None
This was referenced Nov 18, 2024
sambhav-jain-16
added a commit
to sambhav-jain-16/cockroach
that referenced
this pull request
Nov 26, 2024
There was a regression in cockroachdb#135239. The change was reverted and this PR aims to fix the regressions Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
135564: build/teamcity: add changes to enable openmetrics in nightly roachtests r=nameisbhaskar a=sambhav-jain-16 There was a regression in #135239. The change was reverted and this PR aims to fix the regressions Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None 135596: security: bugfix, ensure cert expiry metrics reflect reloaded certs r=angles-n-daemons a=angles-n-daemons security: bugfix, ensure cert expiry metrics reflect reloaded certs The PR #130110 added certificate TTL metrics alongside our existing expiration metrics. Prior to that change, the certificate metrics values were updated on each metrics load. Afterwards, new metrics objects were created for each load of certificates. This created a bug in that the new expiration values would not be found in any of the system exhaust (metrics scrape or tsdb) because the registered metrics objects were the ones created on startup. This new change instead allows the metrics to close the whole CertificateManager object, so that they only need to be created once, and therefore the initial registration of metrics reflects persistently valid values. Release note (bug fix): security.certificate.* metrics will now be updated if a node loads new certificates while running. Epic: none Fixes: #135093 136122: crosscluster/physical: update tokens when altering topology r=dt a=dt Release note: none. Epic: none. This regressed in #135637 which was assigning all conusmer sub-partitions the whole partition due to sharing the original token. 136182: kvserver: use leader leases in various flow control tests r=kvoli a=arulajmani See individual commits for details. Co-authored-by: Sambhav Jain <sambhav.jain@cockroachlabs.com> Co-authored-by: Brian Dillmann <brian.dillmann@cockroachlabs.com> Co-authored-by: David Taylor <tinystatemachine@gmail.com> Co-authored-by: Arul Ajmani <arulajmani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#133035 added changes to the
roachtestbinary to emit openmetrics from benchmarks. This change is intended for nightlies to be able to pass on relevant flags and buckets to export openmetricsEpic: https://cockroachlabs.atlassian.net/browse/CRDB-41852
Release note: None