Skip to content

Comments

build/teamcity: add changes to enable openmetrics in nightly roachtests#135564

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
sambhav-jain-16:CRDB-41992
Nov 26, 2024
Merged

build/teamcity: add changes to enable openmetrics in nightly roachtests#135564
craig[bot] merged 1 commit intocockroachdb:masterfrom
sambhav-jain-16:CRDB-41992

Conversation

@sambhav-jain-16
Copy link
Contributor

@sambhav-jain-16 sambhav-jain-16 commented Nov 18, 2024

There was a regression in #135239.
The change was reverted and this PR aims to fix the regressions

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@sambhav-jain-16 sambhav-jain-16 changed the title Crdb 41992 build/teamcity: add changes to enable openmetrics in nightly roachtests Nov 18, 2024
@sambhav-jain-16 sambhav-jain-16 force-pushed the CRDB-41992 branch 9 times, most recently from 824ae4b to 0181b51 Compare November 25, 2024 09:37
@sambhav-jain-16 sambhav-jain-16 marked this pull request as ready for review November 25, 2024 11:35
@sambhav-jain-16 sambhav-jain-16 requested a review from a team as a code owner November 25, 2024 11:35
@sambhav-jain-16 sambhav-jain-16 requested review from nameisbhaskar and srosenberg and removed request for a team November 25, 2024 11:35
Copy link
Contributor

@DarrylWong DarrylWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a couple benchmark tests that are on the weekly suite. We should export -e EXPORT_OPENMETRICS -e ROACHPERF_OPENMETRICS_CREDENTIALS to the weekly_*.sh scripts as well.

There was a regression in #135239.

Out of curiosity, what exactly was the regression?

@sambhav-jain-16
Copy link
Contributor Author

Out of curiosity, what exactly was the regression?

An error was introduced while trying to read EXPORT_OPENMETRICS as being an unbounded variable.

I think there's a couple benchmark tests that are on the weekly suite. We should export -e EXPORT_OPENMETRICS -e ROACHPERF_OPENMETRICS_CREDENTIALS to the weekly_*.sh scripts as well.

ok

Copy link
Contributor

@nameisbhaskar nameisbhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There was a regression in cockroachdb#135239.
The change was reverted and this PR aims to fix the regressions

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852

Release note: None
@sambhav-jain-16
Copy link
Contributor Author

TFTR!

bors r=@nameisbhaskar

@craig craig bot merged commit b6bfe7b into cockroachdb:master Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants