Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: enable usage of RocksDB DeleteRange by default #14391

Merged
merged 1 commit into from
Mar 31, 2017
Merged

storage: enable usage of RocksDB DeleteRange by default #14391

merged 1 commit into from
Mar 31, 2017

Conversation

petermattis
Copy link
Collaborator

@petermattis petermattis commented Mar 27, 2017 •
edited by rjnn
Loading

This change is Reviewable

@petermattis
Copy link
Collaborator Author

The TestStopServer failure is reproducible and worrisome. Happens very quickly usingmake stress PKG=./testutils/testcluster/ TESTS=TestStopServer.

@bdarnell
Copy link
Contributor

It doesn't look like we've been running with this enabled on the test clusters either (at least not in the currently checked-in configs). Should we try setting that environment variable on a few clusters before making it the default?

@petermattis
Copy link
Collaborator Author

Should we try setting that environment variable on a few clusters before making it the default?

Hmm, we were running this on blue for a while. When did that change?

petermattis added a commit to petermattis/cockroach that referenced this pull request Mar 28, 2017
@petermattis
storage/engine: fix DeleteRange+ApplyBatchRepr
6b62283 
Added support for DeleteRange to DBBatchInserter. This missing support
was causing test failures and various data corruption when enabling
COCKROACH_ENABLE_FAST_CLEAR_RANGE after cockroachdb#14138 started using
ApplyBatchRepr on batches containing DeleteRange operations.

See cockroachdb#14391
@petermattis petermattis mentioned this pull request Mar 28, 2017
Merged
@petermattis
Copy link
Collaborator Author

Figured out the test failure (see #14416). We should definitely enable COCKROACH_ENABLE_FAST_CLEAR_RANGE on the test clusters for a while before merging this PR.

@petermattis petermattis changed the title storage: enable usage of RocksDB DeleteRange by default [DO NOT MERGE] storage: enable usage of RocksDB DeleteRange by default Mar 28, 2017
petermattis added a commit to petermattis/cockroach that referenced this pull request Mar 28, 2017
@petermattis
storage/engine: fix DeleteRange+ApplyBatchRepr
0ffaf1a 
Added support for DeleteRange to DBBatchInserter. This missing support
was causing test failures and various data corruption when enabling
COCKROACH_ENABLE_FAST_CLEAR_RANGE after cockroachdb#14138 started using
ApplyBatchRepr on batches containing DeleteRange operations.

See cockroachdb#14391
@petermattis petermattis force-pushed the pmattis/fast-clear-range branch from b7f6a21 to 8fbb75b Compare March 28, 2017 15:05
@petermattis petermattis force-pushed the pmattis/fast-clear-range branch from 8fbb75b to 842bde1 Compare March 29, 2017 20:04
@petermattis petermattis changed the title [DO NOT MERGE] storage: enable usage of RocksDB DeleteRange by default storage: enable usage of RocksDB DeleteRange by default Mar 30, 2017
@petermattis
Copy link
Collaborator Author

COCKROACH_ENABLE_FAST_CLEAR_RANGE was enabled on 3 test clusters and it looks good so far. I plan to merge this PR after this week's beta goes out.

@petermattis petermattis merged commit 320f711 into cockroachdb:master Mar 31, 2017
@petermattis petermattis deleted the pmattis/fast-clear-range branch March 31, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamird tamird tamird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermattis @bdarnell @tamird