storage/engine: fix DeleteRange+ApplyBatchRepr

[petermattis]

Added support for DeleteRange to DBBatchInserter. This missing support
was causing test failures and various data corruption when enabling
COCKROACH_ENABLE_FAST_CLEAR_RANGE after #14138 started using
ApplyBatchRepr on batches containing DeleteRange operations.

See #14391

---

This change is 

[tamird]

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

pkg/storage/engine/db.cc, line 513 at r1 (raw file):

  }
  // NB: we don't support DeleteRangeCF yet which causes us to pick up
  // the default implementation that returns an error.

if the default implementation returns an error, how come we saw data corruption?

---

Comments from Reviewable

[petermattis]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

pkg/storage/engine/db.cc, line 513 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

if the default implementation returns an error, how come we saw data corruption?

I was ignoring an error. Now fixed.

PS Data corruption == batch was only partially applied.

---

Comments from Reviewable

[tamird]

---

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

---

Comments from Reviewable