blobs: register Blob service with DRPC server
#148500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
cthumuluru-crdb
approved these changes
Jun 18, 2025
Contributor
cthumuluru-crdb
left a comment
cthumuluru-crdb
left a comment
There was a problem hiding this comment.
LGTM! Please add a ticket to both commit message and PR before committing this change.
shubhamdhama
force-pushed
the
register-svc-blobs
branch
from
bbc122e to
9e59f07
Compare
Enable the `Blob` service on the DRPC server in addition to gRPC. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
cthumuluru-crdb
force-pushed
the
register-svc-blobs
branch
from
9e59f07 to
22ff635
Compare
Contributor
|
bors r+ |
Contributor
|
Build failed: |
Contributor
|
bors r+ |
Contributor
celeste-cockroachdb
bot
added
v25.3.0-prerelease
and removed
target-release-25.3.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
Blobservice on the DRPC server in addition to gRPC. This is controlled byrpc.experimental_drpc.enabled(off by default).This change is part of a series and is similar to: #146926
Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect.
Epic: CRDB-48925
Release note: None