roachtest: remove error assertion from panic node mutator #148596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The panic node mutator error assertion is causing flakes, as the error is not always the specific TCP error that is expected even if the panic is working as it should. Given that we are not testing the panic implementation here, asserting on the node being down should be enough. Epic: None Release note: None
herkolategan
requested review from
DarrylWong,
golgeek and
srosenberg
and removed request for
a team
Member
|
This change is |
Collaborator
Author
|
@DarrylWong I did notice the comment you left on the original PR: |
stevendanna
approved these changes
Jun 20, 2025
DarrylWong
approved these changes
Jun 20, 2025
Collaborator
Author
|
TFTRs! bors r=stevendann,DarrylWong |
Contributor
celeste-cockroachdb
bot
added
v25.3.0-prerelease
and removed
target-release-25.3.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The panic node mutator error assertion is causing flakes, as the error is not always the specific TCP error that is expected even if the panic is working as it should.
Given that we are not testing the panic implementation here, asserting on the node being down should be enough.
Fixes: #148586
Epic: None
Release note: None