server,cli: extract QuorumRecovery and register with DRPC server
#148785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
…erver This is a follow-up to cockroachdb#145195, where we extracted `KVBatch` from the `Internal` service. Here, we do the same with `QuorumRecovery`. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Fixes: cockroachdb#148726 Epic: CRDB-48925 Release note: None
shubhamdhama
force-pushed
the
register-svc-node
branch
from
3a8166d to
b6286d7
Compare
shubhamdhama
changed the title
NodeService and register with DRPC serverQuorumRecovery and register with DRPC server
tbg
approved these changes
Jul 1, 2025
Contributor
Author
|
TFTR! bors r=tbg |
Contributor
|
Build succeeded: |
celeste-cockroachdb
bot
added
v25.4.0-prerelease
and removed
target-release-25.4.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #145195, where we extracted
KVBatchfrom theInternalservice. Here, we do the same withQuorumRecovery. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC.We also enable this service on the DRPC server. This is controlled by
rpc.experimental_drpc.enabled(off by default).This change is part of a series and is similar to: #146926
Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect.
Fixes: #148726
Epic: CRDB-48925
Release note: None