allocator: correct logging for priority assertion #152675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an incorrect log statement in computeAction for priority assertions. The log was mistakenly emitted even when the priority was not -1. Related: cockroachdb#152512 Release note: none
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
tbg
approved these changes
Aug 28, 2025
Contributor
Author
|
TFTR! bors r=tbg |
craig bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
152675: allocator: correct logging for priority assertion r=tbg a=wenyihu6 This commit fixes an incorrect log statement in computeAction for priority assertions. The log was mistakenly emitted even when the priority was not -1. Related: #152512 Epic: none Release note: none Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com>
Contributor
|
Build failed: |
Contributor
Author
|
CI seems to be hanging https://mesolite.cluster.engflow.com/invocations/default/6a2e3406-7dca-49e2-af9b-c03aa265990d. Not sure why. bors retry |
Collaborator
|
It's a pre-emption of the VM running the CI job. |
Contributor
This was referenced Aug 29, 2025
celeste-cockroachdb
bot
added
v25.4.0-prerelease
and removed
target-release-25.4.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an incorrect log statement in computeAction for priority
assertions. The log was mistakenly emitted even when the priority was not -1.
Related: #152512
Epic: none
Release note: none