Skip to content

allocator: correct logging for priority assertion #152675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craig merged 1 commit into from
Aug 28, 2025
Merged

allocator: correct logging for priority assertion #152675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/kv/kvserver/allocator/allocatorimpl/allocator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,10 +965,12 @@ func (a *Allocator) ComputeAction(
// the caller expects the processing logic to be invoked even if there's a
// priority inversion. If the priority is not -1, the range might be re-queued
// to be processed with the correct priority.
if priority == -1 && buildutil.CrdbTestBuild {
log.Dev.Fatalf(ctx, "allocator returned -1 priority for range %s: %v", desc, action)
} else {
log.Dev.Warningf(ctx, "allocator returned -1 priority for range %s: %v", desc, action)
if priority == -1 {
if buildutil.CrdbTestBuild {
log.Dev.Fatalf(ctx, "allocator returned -1 priority for range %s: %v", desc, action)
} else {
log.Dev.Warningf(ctx, "allocator returned -1 priority for range %s: %v", desc, action)
}
}
return action, priority
}
Expand Down