roachtest: de-flake acceptance/rapid-restart #30496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The teamcity output is so much less pleasant to read. Better to just open the artifact sometimes. Release note: None
The kill signal was sometimes a noop (when issued before the process to be killed started). Prior to this patch, that would leave the test stuck. Fixes cockroachdb#30475. Release note: None
|
This change is |
petermattis
approved these changes
Sep 21, 2018
There was a problem hiding this comment.
Thanks for fixing this!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Sep 21, 2018
30496: roachtest: de-flake acceptance/rapid-restart r=petermattis a=tschottdorf The kill signal was sometimes a noop (when issued before the process to be killed started). Prior to this patch, that would leave the test stuck. Fixes #30475. Release note: None 30497: roachtest: wait for teardown if local test times out r=petermattis a=tschottdorf I suspect not doing so previously can cause issues like #30397. Local roachtests are simply not set up to run concurrently, but once a test times out we're doing that (though we attempt to teardown the cluster, tests can apparently still "do stuff" with it, for example the rapid restarts test was running one-off invocations of CockroachDB via Exec; also note the comment near the added lines suggesting that in local clusters we may not actually be destroying them). We can revisit this when we allow multiple local clusters in parallel, as we can then use a different one. Optimistically: Fixes #30397. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kill signal was sometimes a noop (when issued before the process to be
killed started). Prior to this patch, that would leave the test stuck.
Fixes #30475.
Release note: None