backport-2.1: assorted testing-related backports #30503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw a consistency failure in cockroachdb#29252 that would've been much more useful had it occurred close to the time around which the inconsistency must have been introduced. Instead of leaving it to chance, add a switch that runs aggressive checks in (roach) tests that want them such as the clearrange test. Release note: None
Unfortunately, the method to determine the range count is quite slow since crdb_internal.ranges internally sends an RPC for each range to determine the leaseholder. Anecdotally, I've seen ~25% of the merges completed after less than 15 minutes. I know that it's slowing down over time, but @benesch will fix that. Also throws in aggressive consistency checks so that when something goes out of sync, we find out right there. Release note: None
Nobody likes scrolling for minutes at a time. Release note: None
Previously, the message for existing issues didn't contain the output. This was annoying as you care about the most recent failures first and foremost, typically. Release note: None
This tends to create duplicate issues for a similar root cause. I think it's better to collect failures from different branches in an umbrella issue, even though it implies that we need to be more careful about closing them. Release note: None
all of its subtests are already stable, but in running a test locally I noticed that the top-level test was marked as passing as unstable. I'm not sure, but this might mean that the top-level test would actually not fail? Either way, better to mark it as stable explicitly. We should also spend some thought on how diverging notions of Stable in sub vs top level test are treated, not sure that this is well-defined. Release note: None
Closes cockroachdb#27717. Release note: None
Perhaps: Fixes cockroachdb#27253. Release note: None
setReplicaID refreshes the proposal and was thus synchronously writing to the commandProposed chan. This channel could have filled up due to an earlier reproposal already, deadlocking the test. Fixes cockroachdb#28132. Release note: None
AddReplicas was verifying that a replica had indeed been added, but there's no guarantee that the replicate queue wouldn't have removed it in the meantime. Attempt to work around this somewhat. The real solution is not to provide that guarantee, but some tests likely rely on it (and the failure is extremely rare, i.e. the new for loop basically never runs). Observed in cockroachdb#28368. Release note: None
Fixes cockroachdb#28607. Release note: None
Fixes cockroachdb#29665. Release note: None
The test could deadlock if the callback fired during shutdown due to a send on an unbuffered channel. Haven't been able to get this to fail after this commit. Fixes cockroachdb#29982. Release note: None
The teamcity output is so much less pleasant to read. Better to just open the artifact sometimes. Release note: None
The kill signal was sometimes a noop (when issued before the process to be killed started). Prior to this patch, that would leave the test stuck. Fixes cockroachdb#30475. Release note: None
I suspect not doing so previously can cause issues like cockroachdb#30397. Local roachtests are simply not set up to run concurrently, but once a test times out we're doing that (though we attempt to teardown the cluster, tests can apparently still "do stuff" with it, for example the rapid restarts test was running one-off invocations of CockroachDB via Exec; also note the comment near the added lines suggesting that in local clusters we may not actually be destroying them). We can revisit this when we allow multiple local clusters in parallel, as we can then use a different one. Optimistically: Fixes cockroachdb#30397. Release note: None
|
This change is |
tbg
deleted the
backport2.1-29646-30420-30419-30405-30450-30451-30452-30455-30456-30373-30479-30496-30497
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release