release-19.1: storage/bulk: push buffer-sort down to BulkAdder #36377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pushes the buffering and sorting of out-of-order keys down to the BulkAdder. This pattern is common everywhere we produce out-of-order KVs that we want to ingest in bulk -- we need to sort them, both for the ordering property of SSTs but also for grouping. Evidence suggests that changes in buffering and splitting could lead to significant changes in overall ingest performance -- buffering more or even just buffering/splitting smarter affects the spans of produced SSTs which in turn directly affects how expensive overall ingestion is -- due to both some cockroach-specific factors like stats recomputation as well as other factors like compaction-derived write-amplification. While I'm here: Embedding `backfiller` in the `chunkbackfiller` implementations, and in turn embedding `chunkbackfiller` in `backfiller` created a loop, whereby a stuct with no methods could implement `chunkbackfiller` (leading to a NPE at runtime?). Release note: none.
Release note (sql change): add settings to control buffering in index backfiller.
Member
|
This change is |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #36192.
/cc @cockroachdb/release
This pushes the buffering and sorting of out-of-order keys down to the
BulkAdder. This pattern is common everywhere we produce out-of-order KVs
that we want to ingest in bulk -- we need to sort them, both for the
ordering property of SSTs but also for grouping.
Evidence suggests that changes in buffering and splitting could lead to
significant changes in overall ingest performance -- buffering more or
even just buffering/splitting smarter affects the spans of produced SSTs
which in turn directly affects how expensive overall ingestion is -- due
to both some cockroach-specific factors like stats recomputation as well
as other factors like compaction-derived write-amplification.
While I'm here: Embedding
backfillerin thechunkbackfillerimplementations, and in turn embedding
chunkbackfillerinbackfillercreated a loop, whereby a stuct with no methods could implement
chunkbackfiller(leading to a NPE at runtime?).Release note: none.