Revert "Revert "c-deps: fix assertion-enabled builds"" #41153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
petermattis
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ajkr, @petermattis, and @tbg)
build/teamcity-testrace.sh, line 54 at r1 (raw file):
TESTTIMEOUT=45m \ TESTFLAGS='-v' \ ENABLE_ROCKSDB_ASSERTIONS=1 2>&1 \
Should we pass in ENABLE_LIBROACH_ASSERTIONS=1 here too?
This reverts commit 6d6b5c4. In the same PR I upgraded RocksDB to pull in cockroachdb/rocksdb#59, which relaxes the assertion whose failure led to the original revert. Release justification: run `make testrace` in teamcity with rocksdb assertions enabled to increase our bug-finding chances Release note: None
ajkr
force-pushed
the
refix-rocks-assertions
branch
from
8914c87
to
dd865fd
Compare
ajkr
commented
Sep 28, 2019
There was a problem hiding this comment.
TFTR.
Reviewable status:
build/teamcity-testrace.sh, line 54 at r1 (raw file):
Previously, petermattis (Peter Mattis) wrote…
Should we pass in
ENABLE_LIBROACH_ASSERTIONS=1here too?
Done.
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 28, 2019
41153: Revert "Revert "c-deps: fix assertion-enabled builds"" r=ajkr a=ajkr This reverts commit 6d6b5c4. In this same PR I upgraded RocksDB to pull in cockroachdb/rocksdb#59, which relaxes the assertion whose failure led to the original revert. Release justification: run `make testrace` in teamcity with rocksdb assertions enabled to increase our bug-finding chances Release note: None Co-authored-by: Andrew Kryczka <andrew.kryczka2@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6d6b5c4.
In this same PR I upgraded RocksDB to pull in
cockroachdb/rocksdb#59, which relaxes the
assertion whose failure led to the original revert.
Release justification: run
make testracein teamcity with rocksdbassertions enabled to increase our bug-finding chances
Release note: None