Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "c-deps: fix assertion-enabled builds"" #41153

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Revert "Revert "c-deps: fix assertion-enabled builds"" #41153

merged 1 commit into from
Sep 28, 2019

Commits on Sep 28, 2019

  1. Revert "Revert "c-deps: fix assertion-enabled builds"" 

    This reverts commit 6d6b5c4.

In the same PR I upgraded RocksDB to pull in
cockroachdb/rocksdb#59, which relaxes the
assertion whose failure led to the original revert.

Release justification: run `make testrace` in teamcity with rocksdb
assertions enabled to increase our bug-finding chances

Release note: None
    @ajkr
    ajkr committed Sep 28, 2019
    Configuration menu
    Copy the full SHA
    dd865fd View commit details
    Browse the repository at this point in the history