sqlsmith: silence sqlsmith issue filing after query timeout #45459
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rohany)
pkg/cmd/roachtest/sqlsmith.go, line 164 at r1 (raw file):
// should not cause an issue to be raised, as they most likely are // just timing out. c.l.Printf("query timed out, but did not cancel execution:\n%s;", stmt)
I think we should also file a bug that SET statement_timeout is not always respected, and leave a TODO here to fail the test once that issue is resolved.
Release note: None
rohany
force-pushed
the
sqlsmith-timeout-err
branch
from
02c0cdf
to
5e48731
Compare
|
bors r=yuzefovich |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None