ui: CSS modules for Table components #47606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
❌ The GitHub CI (Cockroach) build has failed on d365bfbb. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
koorosh
force-pushed
the
koorosh/ui-statements-extraction--sortable-table
branch
from
d365bfb
to
c782a36
Compare
koorosh
changed the title
23 tasks
koorosh
force-pushed
the
koorosh/ui-statements-extraction--sortable-table
branch
2 times, most recently
from
a74c2bd
to
d0b4a14
Compare
koorosh
force-pushed
the
koorosh/ui-statements-extraction--sortable-table
branch
from
d0b4a14
to
db34934
Compare
koorosh
force-pushed
the
koorosh/ui-statements-extraction--sortable-table
branch
from
db34934
to
8068545
Compare
koorosh
force-pushed
the
koorosh/ui-statements-extraction--sortable-table
branch
3 times, most recently
from
093ffbf
to
02873ff
Compare
To test styles isolation for statements page we need storybook which displays entire Statements screen only. To make it work, RouterProvider decorator is added which connects router to dummy (empty) store. `statementsPage.fixture.ts` file contains snapshot of required props for StatementsPage component Release note: None
- refactor fonts imports to correctly resolve paths when module is required from different locations; - move all files related to PlanView component under `planView` directory - Added story for PlanView component Release note: None
Previously, class names were constructed by simply accessing style modules class names and assigning it to classes. It was cumbersome and not readable at all. To enhance this, `classnames/bind` alternate is used, which allows simply put class names. Release note: None
This change refactors components to use CSS modules and incorporate all required styles without any external dependencies and prevent styles altering from outside. It affects several components which tightly coupled with StatementsTable and couldn't be changed separately. Following component are changed: - HighlightedText - Drawer - StatementsTable - SortableTable Note, that `StatementsTable#makeCommonColumns` function is refactored to provide custom styles from parent to child components via props instead of overriding styles. Storybook is extended to show some components as independent units or in context of `StatementTable` component (if it is only the way components work). Release note: None
koorosh
force-pushed
the
koorosh/ui-statements-extraction--sortable-table
branch
from
02873ff
to
af044f0
Compare
dhartunian
approved these changes
Jun 4, 2020
|
bors r+ |
Merge conflict (retrying...) |
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jun 9, 2020
48012: ui: CSS modules for Statements filter section r=koorosh a=koorosh Depends on #47606 Related to #47527 This change refactors following components to use CSS modules instead of styles defined as global: - Dropdown - Search - PageConfig Release note: None Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #47513
Related to #47527
This change refactors components to use CSS modules and
incorporate all required styles without any external
dependencies and prevent styles altering from outside.
It affects several components which tightly
coupled with StatementsTable and couldn't be changed
separately.
Following component are changed:
Note, that
StatementsTable#makeCommonColumnsfunctionis refactored to provide custom styles from parent to
child components via props instead of overriding styles.
Storybook is extended to show some components as independent
units or in context of
StatementTablecomponent (if it isonly the way components work).
Release note: None