ui: CSS modules for Statements filter section #48012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
koorosh
force-pushed
the
koorosh/ui-statements-extraction--statements-filter
branch
from
42c9bb4
to
9418226
Compare
|
❌ The GitHub CI (Cockroach) build has failed on 9418226d. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
koorosh
force-pushed
the
koorosh/ui-statements-extraction--statements-filter
branch
2 times, most recently
from
7b84114
to
0fcf1e2
Compare
koorosh
force-pushed
the
koorosh/ui-statements-extraction--statements-filter
branch
2 times, most recently
from
257b2f1
to
219fe4c
Compare
dhartunian
approved these changes
Jun 4, 2020
koorosh
force-pushed
the
koorosh/ui-statements-extraction--statements-filter
branch
4 times, most recently
from
053e820
to
ffce810
Compare
This change refactors following components to use CSS modules instead of styles defined as global: - Dropdown - Search - PageConfig Release note: None
koorosh
force-pushed
the
koorosh/ui-statements-extraction--statements-filter
branch
from
ffce810
to
8677bc0
Compare
|
bors r+ |
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jun 9, 2020
48090: ui: CSS modules for Statements Details page r=koorosh a=koorosh Depends on #48012 Related to #47527 Following components are refactored to use CSS modules instead of global styles: - Statement Details page - Statements Diagnostics components - Anchor - Text - Empty Before, `Empty` component had styles which override Text, and Anchor components. Now, these styles are passed via `className` component props and custom styles defined by outer component. Release note: None Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #47606
Related to #47527
This change refactors following components to
use CSS modules instead of styles defined as
global:
Release note: None